fix: Reset offset count when closing modal or when filter query changes #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe updates primarily focus on enhancing pagination and filter functionalities across different components in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
mertmit
approved these changes
Mar 22, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (4 hunks)
- packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (1 hunks)
- packages/nc-gui/composables/useLTARStore.ts (2 hunks)
Additional comments: 12
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (6)
- 62-62: The introduction of
resetChildrenListOffsetCountis aligned with the PR's objective to manage offset counts effectively. This function is crucial for ensuring the UI's state remains consistent with user actions.- 74-77: Resetting the offset count when the modal closes is a good practice to ensure that stale data does not affect the user experience when the modal is reopened. This change is well-implemented.
- 216-216: Ensuring the offset count is reset upon component unmounting is a good cleanup practice, especially for SPA where component instances can be reused. This helps in avoiding potential bugs related to stale state.
- 221-225: The update to
onFilterChangeto reset both the pagination page and the offset count upon a filter change is crucial for maintaining accurate state in response to user actions. This change correctly addresses the PR's objectives.- 258-258: Using the
@changeevent to triggeronFilterChangeensures that the offset count is reset immediately when the filter query changes, which is a good practice for maintaining the UI's responsiveness and accuracy.- 258-258: The binding of
onFilterChangeto the@changeevent in the template is correctly implemented, ensuring that the offset count reset logic is triggered as expected when the filter query changes.packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (4)
- 259-259: Adding a call to
resetChildrenExcludedOffsetCount()in theonUnmountedlifecycle hook is a good practice for ensuring that the component's state is correctly reset upon unmounting. This helps in maintaining a clean state for SPA where components might be reused.- 259-259: Resetting the
childrenExcludedListPagination.queryalongside the offset count in theonUnmountedlifecycle hook ensures that both the pagination state and the filter query are reset, which is important for maintaining the accuracy and relevance of the displayed items.- 259-259: Removing the event listener for
keydownevents in theonUnmountedlifecycle hook is a crucial cleanup step to avoid potential memory leaks and ensure that event handlers do not persist beyond the lifecycle of the component.- 259-259: The binding of
onFilterChangeto the@changeevent in the template is correctly implemented, ensuring that the offset count reset logic is triggered as expected when the filter query changes.packages/nc-gui/composables/useLTARStore.ts (2)
- 557-559: The addition of
resetChildrenListOffsetCountfunction looks good. It's a straightforward implementation for resetting thechildrenListOffsetCount. Ensure this function is called in the appropriate scenarios to effectively manage the offset count.- 591-592: The update to include
resetChildrenListOffsetCountin the return object of the composable is correctly implemented. This ensures that the function is accessible to consumers of the composable.
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of
Summary by CodeRabbit