Nc calendar enable

[dstala]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

Summary by CodeRabbit

• New Features

  • Introduced a new directive for enhanced calendar view handling in multiple components.
  • Added functionality to display a message when the calendar range is empty in the SideMenu.
  • Enhanced calendar views (Day, Month, Week) with new bindings and directives for improved user interaction.
  • Implemented a new case in the export service for handling 'calendar_range'.
  • Conditionally created calendar column properties based on the calendar view type during import.

• Enhancements

  • Updated the calendar range checking mechanism to use optional chaining for more reliable evaluation.
  • Modified the calendar mode toolbar to handle changing the calendar view effectively.
  • Improved the text for adding a date field in the CalendarRange component for clarity.

• Bug Fixes

  • Removed unused Easter Egg functionality from the CreateViewBtn component.
  • Eliminated commented-out code for better code cleanliness.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates primarily focus on enhancing the calendar functionality across the application. Key changes include the introduction of a new Vue directive v-e for dynamic value binding within calendar components, improvements to conditional rendering based on the presence and length of calendarRange, and updates to the calendar's UI and backend handling. Additionally, obsolete Easter Egg functionality was removed, and improvements were made to the export and import services to support calendar_range data.

Changes

Files	Change Summary
.../dashboard/TreeView/CreateViewBtn.vue	Removed isEasterEggEnabled functionality.
.../calendar/DayView/DateTimeField.vue, .../calendar/WeekView/DateTimeField.vue	Added v-e binding with computed and dynamic values respectively.
.../calendar/MonthView.vue	Added new directive v-e with value ['c:calendar:month-view-more'].
.../calendar/SideMenu.vue, .../calendar/index.vue	Updated v-if condition to check calendarRange length with optional chaining. Added v-else block in SideMenu for empty calendarRange. Updated v-e attribute in NcButton.
.../toolbar/CalendarMode.vue, .../toolbar/CalendarRange.vue	Updated event binding for changing calendar view. Removed unused code and updated button text.
.../composables/useCalendarViewStore.ts	Improved sidebar and calendar data loading checks for calendarRange.value length.
.../jobs/jobs/export-import/export.service.ts, .../jobs/jobs/export-import/import.service.ts	Added handling for calendar_range in export and import services.
.../services/calendar-datas.service.ts	Modified access and length check for ranges with optional chaining.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7e414ed and 6b92ccb.

Files selected for processing (12)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (2 hunks)
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (3 hunks)
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/index.vue (1 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue (2 hunks)
• packages/nc-gui/composables/useCalendarViewStore.ts (4 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts (2 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts (1 hunks)
• packages/nocodb/src/services/calendar-datas.service.ts (3 hunks)

Learnings (1)

packages/nocodb/src/services/calendar-datas.service.ts (1)

The project uses a global error handling mechanism to catch and handle errors, making explicit local error handling within methods unnecessary for certain cases.

Additional comments (23)

packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue (2)

• 47-47: The update to the event binding for changing the calendar view using the v-e directive is correctly implemented and aligns with the PR objectives.
• 67-67: The update to the event binding for changing the calendar view in the dropdown menu using the v-e directive is correctly implemented and aligns with the PR objectives.

packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (1)

• 103-115: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [112-158]

Assuming the removal of isEasterEggEnabled functionality is correctly implemented as mentioned in the summary, this simplifies the component and aligns with the PR objectives.

packages/nocodb/src/services/calendar-datas.service.ts (3)

• 139-141: The use of optional chaining to access properties of ranges in the getCalendarRecordCount method is a good practice that enhances code safety and robustness.
• 168-168: The use of optional chaining in the forEach loop when iterating over ranges is correctly applied, ensuring the code is more resilient to potential undefined values.
• 206-206: The use of optional chaining when iterating over calendarRange?.ranges in the buildFilterArr method is a good practice, enhancing code safety.

packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue (2)

• 102-102: Removing commented-out code is a good practice as it cleans up the codebase and improves readability.
• 226-226: Updating the button text to "Add date field" clarifies the action performed by the button and enhances user experience.

packages/nc-gui/components/smartsheet/calendar/index.vue (1)

• 285-285: Updating the conditional check to v-if="calendarRange?.length" ensures components are rendered only when calendarRange has items, enhancing the logic and user experience.

packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (3)

• 372-372: Using optional chaining to check the length of calendarRange for conditional rendering is a good practice, ensuring components are shown only when relevant data is present.
• 386-386: The update to the event binding with the v-e attribute in the NcButton component aligns with the PR objectives and enhances functionality.
• 443-453: Adding a new div block with conditional rendering to display a message when calendarRange is empty improves user experience by providing clear feedback.

packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts (1)

• 236-251: The addition of the 'calendar_range' case to handle mapping specific properties for calendar ranges is well-integrated with the existing code structure. It correctly uses idMap for ID translation, aligning with the handling of similar cases.

Consider adding a brief comment explaining the mapping process for future maintainability.

packages/nc-gui/components/smartsheet/calendar/MonthView.vue (1)

• 762-762: The addition of the v-e directive to the 'view more' button is consistent with Vue's custom directive patterns. Ensure that the directive's implementation and its integration with the component's event handling system are thoroughly verified for correctness and efficiency.

packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (1)

• 788-788: Consider adding comments to explain the purpose and functionality of the new v-e directive for future maintainability and clarity for other developers.

packages/nc-gui/composables/useCalendarViewStore.ts (4)

• 315-316: The addition of a check for calendarRange.value?.length before proceeding with loading sidebar data is a good practice to ensure that operations are only performed when necessary.
• 343-343: The addition of a check for calendarRange.value?.length before proceeding with fetching active dates is a good practice to ensure that operations are only performed when necessary.
• 437-438: The addition of a check for calendarRange.value?.length before proceeding with loading calendar data is a good practice to ensure that operations are only performed when necessary.
• 598-598: The addition of a check for calendarRange.value?.length before proceeding with loading sidebar data is a good practice to ensure that operations are only performed when necessary.

packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (3)

• 956-956: The v-e directive is used here without prior definition or import in the script section. Ensure that this directive is globally registered or imported correctly in this component. If it's a custom directive intended for handling events or other specific logic, its implementation details should be verified for correctness and efficiency.
• 953-959: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-955]

Overall, the script section is well-structured and makes good use of the Vue Composition API. However, consider the following improvements for maintainability and performance:

1. Refactoring Large Methods: Some methods, like calculateNewRow and onResize, are quite lengthy. Consider breaking these down into smaller, more manageable functions. This will improve readability and maintainability.
2. Debouncing: The useDebouncedRowUpdate function is used for debouncing updates to row properties. Ensure that this debouncing is effectively preventing unnecessary updates and consider adjusting the debounce interval based on user interaction speed.
3. Error Handling: There's minimal error handling throughout the script. For operations that could potentially fail or produce errors (e.g., date manipulations, DOM operations), adding error handling could improve robustness.
4. Performance Considerations: For computed properties and methods that are called frequently or are computationally intensive, ensure that their dependencies are minimized, and consider caching results if appropriate.

• 956-956: The usage of v-e directive here is unique and not standard Vue directive syntax. If it's intended for a custom operation, ensure that its functionality is clearly documented and that it integrates well with the rest of the Vue component lifecycle. Additionally, verify that it does not introduce any side effects or performance issues, especially in the context of a potentially large number of calendar events.

packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts (1)

• 1064-1078: The conditional addition of calendarColProperties based on the ViewTypes.CALENDAR is a good approach to customize column properties for different view types. Ensure that the properties bold, italic, and underline are always present in fcl and are relevant to the CALENDAR view type.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7e414ed and d9c09b6.

Files selected for processing (13)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (2 hunks)
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (3 hunks)
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/index.vue (1 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue (2 hunks)
• packages/nc-gui/composables/useCalendarViewStore.ts (4 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts (2 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts (1 hunks)
• packages/nocodb/src/services/calendar-datas.service.ts (3 hunks)
• tests/playwright/tests/db/views/viewCalendar.spec.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• tests/playwright/tests/db/views/viewCalendar.spec.ts

Files skipped from review as they are similar to previous changes (12)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/index.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue
• packages/nc-gui/composables/useCalendarViewStore.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts
• packages/nocodb/src/services/calendar-datas.service.ts

[github-actions]

Uffizzi Preview deployment-49079 was deleted.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 2e132bf and 7b3b007.

Files selected for processing (15)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (2 hunks)
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (3 hunks)
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/index.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue (2 hunks)
• packages/nc-gui/composables/useCalendarViewStore.ts (4 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts (2 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts (1 hunks)
• packages/nocodb/src/services/calendar-datas.service.ts (3 hunks)
• tests/playwright/pages/Dashboard/Sidebar/index.ts (1 hunks)
• tests/playwright/pages/Dashboard/ViewSidebar/index.ts (1 hunks)
• tests/playwright/tests/db/views/viewCalendar.spec.ts (1 hunks)

Files skipped from review as they are similar to previous changes (13)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/index.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue
• packages/nc-gui/composables/useCalendarViewStore.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts
• packages/nocodb/src/services/calendar-datas.service.ts
• tests/playwright/tests/db/views/viewCalendar.spec.ts

Additional comments (2)

tests/playwright/pages/Dashboard/Sidebar/index.ts (1)

• 113-118: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [208-208]

The removal of the waitForTimeout call in the openProject method is a positive change, as relying on fixed timeouts can lead to flaky tests. However, it's important to ensure that the removal doesn't affect the reliability of the tests. Consider replacing fixed timeouts with more reliable waiting mechanisms, such as waiting for specific elements to be visible or for network requests to complete.

tests/playwright/pages/Dashboard/ViewSidebar/index.ts (1)

• 208-208: Reducing the waitForTimeout duration from 1000 milliseconds to 500 milliseconds in the createView method can potentially improve test execution time. However, ensure this change does not compromise the reliability of the tests by causing them to proceed before the UI is ready for the next action. It's generally recommended to use more deterministic wait conditions, such as waiting for specific elements to appear or disappear, to improve both test reliability and performance.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6d1bf1e and 82cc987.

Files selected for processing (15)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (3 hunks)
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (1 hunks)
• packages/nc-gui/components/smartsheet/calendar/index.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue (2 hunks)
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue (2 hunks)
• packages/nc-gui/composables/useCalendarViewStore.ts (4 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts (2 hunks)
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts (1 hunks)
• packages/nocodb/src/services/calendar-datas.service.ts (3 hunks)
• tests/playwright/pages/Dashboard/Sidebar/index.ts (1 hunks)
• tests/playwright/pages/Dashboard/ViewSidebar/index.ts (1 hunks)
• tests/playwright/tests/db/views/viewCalendar.spec.ts (1 hunks)

Files skipped from review as they are similar to previous changes (15)

• packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue
• packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/MonthView.vue
• packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
• packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
• packages/nc-gui/components/smartsheet/calendar/index.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarMode.vue
• packages/nc-gui/components/smartsheet/toolbar/CalendarRange.vue
• packages/nc-gui/composables/useCalendarViewStore.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts
• packages/nocodb/src/modules/jobs/jobs/export-import/import.service.ts
• packages/nocodb/src/services/calendar-datas.service.ts
• tests/playwright/pages/Dashboard/Sidebar/index.ts
• tests/playwright/pages/Dashboard/ViewSidebar/index.ts
• tests/playwright/tests/db/views/viewCalendar.spec.ts

Additional Context Used