Nc fix: linked records dropdown followup #8415

rameshmane7218 · 2024-05-06T15:17:48Z

Change Summary

Provide summary of changes with issue number if any.

Change type

feat: (new feature for the user, not a new feature for build script)
fix: (bug fix for the user, not a fix to a build script)
docs: (changes to the documentation)
style: (formatting, missing semi colons, etc; no production code change)
refactor: (refactoring production code, eg. renaming a variable)
test: (adding missing tests, refactoring tests; no production code change)
chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

coderabbitai · 2024-05-06T15:18:00Z

Walkthrough

The recent updates across various components in the nc-gui package focus on enhancing customization and user interface elements. These changes include the addition of new properties for customizing button text, updates to functions and styling for improved UI consistency, and adjustments to layout classes for better visual cohesion. Additionally, there are refinements in logical operations within filter functions and enhancements to dropdown elements and link record functionalities.

Changes

File Path	Change Summary
`.../expanded-form/index.vue`, `.../Table.vue`	Added props for button text customization; Updated functions and conditional styling for UI consistency.
`.../BelongsTo.vue`, `.../HasMany.vue`, `.../Links.vue`, `.../ManyToMany.vue`, `.../OneToOne.vue`	Adjusted layout classes `min-h-7.7` for consistent component height.
`.../ItemChip.vue`, `.../LinkRecordDropdown.vue`, `.../LinkedItems.vue`, `.../UnLinkedItems.vue`	Enhanced dropdown styling, added conditional checks in functions, and updated class attributes for better UI responsiveness and interaction.
`.../ListItem.vue`, `.../useViewFilters.ts`	Improved conditional rendering logic, adjusted tooltip buttons, and refined logical operator settings in filter functions.
`nocodb/src/models/Column.ts`	Enhanced handling of default view settings for columns based on foreign key references.

This table summarizes the key changes across different components and scripts, highlighting the focus on enhancing UI elements and refining backend functionalities for better user experience and system performance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 800ba36.

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (2 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review due to trivial changes (4)

packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/composables/useViewFilters.ts

Additional comments not posted (14)

packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2)

Line range hint 1-74: The script setup and reactive state management for handling dropdown visibility and dynamic class manipulation are implemented correctly.

Line range hint 76-78: The template section correctly implements the dropdown functionality with dynamic visibility and class binding, and uses slots effectively for content projection.

packages/nc-gui/components/virtual-cell/HasMany.vue (2)

Line range hint 1-144: The script setup and reactive state management for handling linked records are implemented correctly, with appropriate use of computed properties and watch functions.

146-146: The template section correctly implements the rendering of linked records with dynamic property binding and uses slots effectively for content projection.

packages/nc-gui/components/virtual-cell/Links.vue (2)

Line range hint 1-143: The script setup and reactive state management for handling links between records are implemented correctly, with appropriate use of computed properties and watch functions.

145-145: The template section correctly implements the rendering of links between records with dynamic property binding and uses slots effectively for content projection.

packages/nc-gui/components/virtual-cell/components/ListItem.vue (2)

Line range hint 1-177: The script setup and reactive state management for handling list items are implemented correctly, with appropriate use of computed properties and watch functions.

179-179: The template section correctly implements the rendering of list items with dynamic property binding and uses slots effectively for content projection.

packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (2)

Line range hint 1-308: The script setup and reactive state management for handling unlinked items are implemented correctly, with appropriate use of computed properties and watch functions.

310-310: The template section correctly implements the rendering of unlinked items with dynamic property binding and uses slots effectively for content projection.

packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (2)

Line range hint 1-322: The script setup and reactive state management for handling linked items are implemented correctly, with appropriate use of computed properties and watch functions.

324-324: The template section correctly implements the rendering of linked items with dynamic property binding and uses slots effectively for content projection.

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2)

55-55: The addition of the newRecordSubmitBtnText property is implemented correctly and follows Vue and TypeScript best practices.

912-912: The usage of newRecordSubmitBtnText in the button text is implemented correctly, providing a good fallback mechanism.

packages/nc-gui/components/smartsheet/grid/Table.vue

github-actions · 2024-05-06T15:48:29Z

Uffizzi Preview deployment-51319 was deleted.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 4f89c31.

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and fad30a2.

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 59204fc.

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 0d85e48.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 37623d4.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (3)

packages/nocodb/src/models/Column.ts (3)
Line range hint 106-108: Ensure proper error handling for missing model ID.
- if (!column.fk_model_id) NcError.badRequest('Missing model id');
+ if (!column.fk_model_id) throw NcError.badRequest('Missing model id');
This change ensures that the function throws an error which can be caught in higher-level error handling mechanisms, rather than potentially failing silently.

Line range hint 230-232: Consider adding default case in switch statement for error handling.
+ default:
+   throw new Error('Unsupported UI data type');
Adding a default case will help catch any unsupported UI data types and prevent silent failures.

Line range hint 577-579: Ensure transactional integrity during delete operations.

Consider wrapping the delete operations in a database transaction to ensure that all related deletions are completed atomically. This prevents partial deletions in case of errors.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 2489b66.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files skipped from review as they are similar to previous changes (12)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts

Additional comments not posted (1)

packages/nocodb/src/models/Column.ts (1)
Line range hint 1003-1005: Verify handling of QR and Barcode data types during updates.

Ensure that the handling of QR and Barcode data types is consistent and correct, especially when the UI data type changes.

Verification successful

The verification process has confirmed that the handling of QR and Barcode data types is indeed implemented within the update method of the Column.ts file. The search results show multiple cases where UITypes.QrCode and UITypes.Barcode are explicitly handled, which aligns with the requirements mentioned in the review comment.

Handling of QR and Barcode Data Types Verified:

The codebase includes specific case statements for both UITypes.QrCode and UITypes.Barcode within the update method in Column.ts, ensuring that these data types are managed appropriately during column updates.
Scripts Executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify that QR and Barcode data types are handled correctly during column updates.

# Test: Search for QR and Barcode handling in the update method. Expect: Proper checks and deletions.
rg --type ts 'UITypes.QrCode|UITypes.Barcode' 'Column.ts'
Length of output: 107

Script:
#!/bin/bash
# Find the correct path for Column.ts
fd Column.ts

# Assuming the correct path is found, re-run the rg command to search for QR and Barcode handling
Length of output: 838

Script:
#!/bin/bash
# Re-run the rg command to search for QR and Barcode handling in the correct Column.ts file
rg --type ts 'UITypes.QrCode|UITypes.Barcode' packages/nocodb/src/models/Column.ts
Length of output: 434

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08dfcfa and 8147c27.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files skipped from review as they are similar to previous changes (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts
packages/nocodb/src/models/Column.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 448973c and a06cd93.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (14)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (4 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (1 hunks)
packages/nc-gui/components/virtual-cell/components/ItemChip.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files not reviewed due to errors (1)

packages/nc-gui/components/virtual-cell/components/ItemChip.vue (no review received)

Files skipped from review as they are similar to previous changes (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts
packages/nocodb/src/models/Column.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 448973c and 6878e39.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (14)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (5 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/ItemChip.vue (3 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nc-gui/composables/useViewFilters.ts (1 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files skipped from review as they are similar to previous changes (14)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/ItemChip.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nc-gui/composables/useViewFilters.ts
packages/nocodb/src/models/Column.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a2d265c and b1fa104.

Files ignored due to path filters (1)

packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (5 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/ItemChip.vue (3 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files skipped from review as they are similar to previous changes (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/ItemChip.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nocodb/src/models/Column.ts

…from link record

…s a fix

coderabbitai

Actionable comments posted: 3

Out of diff range and nitpick comments (4)

packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md (4)
Line range hint 24-24: Ensure headings are surrounded by blank lines for proper Markdown formatting.
+ 
Line range hint 35-35: Ensure headings are surrounded by blank lines for proper Markdown formatting.
+ 
Line range hint 85-85: Ensure headings are surrounded by blank lines for proper Markdown formatting.
+ 
Line range hint 29-29: Consider rephrasing to avoid repetitive sentence structure.
- 4. Select the relation type : Either `Has-Many` or `Many-to-Many`.
+ 4. Choose the relation type: Either `Has-Many` or `Many-to-Many`.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a2d265c and 73550e7.

Files ignored due to path filters (3)

packages/nc-gui/lang/en.json is excluded by !**/*.json
packages/noco-docs/static/img/v2/fields/add-link-modal.png is excluded by !**/*.png, !**/*.png
packages/noco-docs/static/img/v2/fields/linked-record-modal.png is excluded by !**/*.png, !**/*.png

Files selected for processing (14)

packages/nc-gui/components/smartsheet/expanded-form/index.vue (2 hunks)
packages/nc-gui/components/smartsheet/grid/Table.vue (5 hunks)
packages/nc-gui/components/virtual-cell/BelongsTo.vue (1 hunks)
packages/nc-gui/components/virtual-cell/HasMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/Links.vue (1 hunks)
packages/nc-gui/components/virtual-cell/ManyToMany.vue (1 hunks)
packages/nc-gui/components/virtual-cell/OneToOne.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/ItemChip.vue (3 hunks)
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue (2 hunks)
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue (8 hunks)
packages/nc-gui/components/virtual-cell/components/ListItem.vue (4 hunks)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (7 hunks)
packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md (2 hunks)
packages/nocodb/src/models/Column.ts (2 hunks)

Files skipped from review as they are similar to previous changes (13)

packages/nc-gui/components/smartsheet/expanded-form/index.vue
packages/nc-gui/components/smartsheet/grid/Table.vue
packages/nc-gui/components/virtual-cell/BelongsTo.vue
packages/nc-gui/components/virtual-cell/HasMany.vue
packages/nc-gui/components/virtual-cell/Links.vue
packages/nc-gui/components/virtual-cell/ManyToMany.vue
packages/nc-gui/components/virtual-cell/OneToOne.vue
packages/nc-gui/components/virtual-cell/components/ItemChip.vue
packages/nc-gui/components/virtual-cell/components/LinkRecordDropdown.vue
packages/nc-gui/components/virtual-cell/components/LinkedItems.vue
packages/nc-gui/components/virtual-cell/components/ListItem.vue
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
packages/nocodb/src/models/Column.ts

Additional Context Used

LanguageTool (7)

packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md (7)

Near line 29: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Either Has-Many or Many-to-Many. 5. Select the table to which the relation is to b...

Near line 52: ‘New record’ might be wordy. Consider a shorter alternative.
Context: ...icon to unlink the record 6. Click on+ New record` button to create and link a new record...

Near line 52: ‘new record’ might be wordy. Consider a shorter alternative.
Context: ...New recordbutton to create and link a new record to the current one 7. Click onLink m...

Near line 53: Unpaired symbol: ‘]’ seems to be missing
Context: ...ore records` to link an existing record Read more 8. Paginat...

Near line 56: ‘new records’ might be wordy. Consider a shorter alternative.
Context: ...w-records) 8. Pagination bar ### Link new records Modal to add new links can be opened b...

Near line 70: ‘New record’ might be wordy. Consider a shorter alternative.
Context: ...+ icon to link the record 6. Click on + New record button to create and link a new record...

Near line 70: ‘new record’ might be wordy. Consider a shorter alternative.
Context: ...New record` button to create and link a new record to the current one 7. Pagination bar :...

coderabbitai · 2024-05-08T10:54:22Z

packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md

+4. To view additional information (expanded record), hover on the card & click on the `<>` icon
+5. Click on the `-` icon to unlink the record


Consider rephrasing to avoid repetition of the phrase "new record" which might be considered wordy.

- 6. Click on the `+ New record` button to create and link a new record to the current one + 6. Click on the `+ Add` button to create and link a new entry to the current one

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

4. To view additional information (expanded record), hover on the card & click on the `<>` icon

5. Click on the `-` icon to unlink the record

4. To view additional information (expanded record), hover on the card & click on the `<>` icon

5. Click on the `-` icon to unlink the record

6. Click on the `+ Add` button to create and link a new entry to the current one

coderabbitai · 2024-05-08T10:54:22Z

packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md

+4. To view additional information (expanded record) before linking, hover on the card & click on the `<>` icon
+5. Click on the `+` icon to link the record


Consider rephrasing to avoid repetition of the phrase "new record" which might be considered wordy.

- 6. Click on the `+ New record` button to create and link a new record to the current one + 6. Click on the `+ Add` button to create and link a new entry to the current one

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

4. To view additional information (expanded record) before linking, hover on the card & click on the `<>` icon

5. Click on the `+` icon to link the record

4. To view additional information (expanded record) before linking, hover on the card & click on the `<>` icon

5. Click on the `+` icon to link the record

6. Click on the `+ Add` button to create and link a new entry to the current one

coderabbitai · 2024-05-08T10:54:23Z

packages/noco-docs/docs/070.fields/040.field-types/040.links-based/010.links.md

-4. Click on the `-` icon to unlink the record 
-5. To view additional information (expanded record), hover on the card & click on the `<>` icon
+4. To view additional information (expanded record), hover on the card & click on the `<>` icon
+5. Click on the `-` icon to unlink the record
 6. Click on `+ New record` button to create and link a new record to the current one 
 7. Click on `Link more records` to link an existing record [Read more](#link-new-records)


Fix the unpaired markdown link syntax.

- 7. Click on `Link more records` to link an existing record [Read more](#link-new-records) + 7. Click on `Link more records` to link an existing record [Read more](#link-new-records)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

7. Click on `Link more records` to link an existing record [Read more](#link-new-records)

7. Click on `Link more records` to link an existing record [Read more](#link-new-records)

rameshmane7218 self-assigned this May 6, 2024

coderabbitai bot reviewed May 6, 2024

View reviewed changes

packages/nc-gui/components/smartsheet/grid/Table.vue Show resolved Hide resolved

packages/nc-gui/components/smartsheet/grid/Table.vue Outdated Show resolved Hide resolved

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 800ba36 to 4f89c31 Compare May 6, 2024 16:51

coderabbitai bot reviewed May 6, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 4f89c31 to fad30a2 Compare May 6, 2024 16:56

coderabbitai bot reviewed May 6, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from fad30a2 to 59204fc Compare May 6, 2024 17:26

coderabbitai bot reviewed May 6, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 59204fc to 0d85e48 Compare May 6, 2024 19:38

coderabbitai bot reviewed May 6, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 0d85e48 to 37623d4 Compare May 6, 2024 20:03

coderabbitai bot reviewed May 6, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 37623d4 to 2489b66 Compare May 7, 2024 05:33

coderabbitai bot reviewed May 7, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 2489b66 to 8147c27 Compare May 7, 2024 05:41

coderabbitai bot reviewed May 7, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 8147c27 to a06cd93 Compare May 7, 2024 12:00

coderabbitai bot reviewed May 7, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from a06cd93 to 6878e39 Compare May 7, 2024 13:30

coderabbitai bot reviewed May 7, 2024

View reviewed changes

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from 6878e39 to b1fa104 Compare May 8, 2024 10:30

coderabbitai bot reviewed May 8, 2024

View reviewed changes

rameshmane7218 added 6 commits May 8, 2024 10:49

fix(nc-gui): update link record dropdown border radius

a701efb

fix(nc-gui): move link/unlink btn to the right side

c3a0244

fix(nc-gui): update placeholder text color

c83bead

fix(nc-gui): reduce link record dropdown bottom bar padding x

8ff019c

fix(nc-gui): update expanded form save btn text in create new record …

f4e344e

…from link record

fix(nc-gui): grid active cell border issue

2315812

rameshmane7218 and others added 16 commits May 8, 2024 10:49

fix(nc-gui): link record dropdown trigger & dropdown spacing

c6e8217

fix(nc-gui): link record footer btn size

4f7b211

fix(nc-gui): link record loading state

e6b727d

fix(nc-gui): update link record search input icon

f0f31fb

fix(nc-gui): update link record item skeleton

20412e4

fix(nc-gui): update grid row hover & selected state bg color

7340262

fix(nc-gui): add tooltip on hover over expand icon

bc57008

fix(nc-gui): link record tooltip issue

a6be263

fix(nc-gui): update search query empty state status

285a553

fix(nc-gui): bt cell ui fixes

1030456

feat(nc-gui): resizable link record dropdown

76f390e

fix(nc-gui): external DB, fields re-order to re-align sub fields need…

10856cf

…s a fix

chore(nc-gui): lint

c8a0dd5

fix(nc-gui): bt & oto cell unlink & link btn visibility issue

30038e1

fix(nc-gui): pr review changes

3f25ccb

fix: docs

73550e7

o1lab force-pushed the nc-fix/link-record-modal-ui-fixes branch from b1fa104 to 73550e7 Compare May 8, 2024 10:49

dstala approved these changes May 8, 2024

View reviewed changes

coderabbitai bot reviewed May 8, 2024

View reviewed changes

dstala merged commit d4fa6a8 into develop May 8, 2024
22 of 23 checks passed

dstala deleted the nc-fix/link-record-modal-ui-fixes branch May 8, 2024 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nc fix: linked records dropdown followup #8415

Nc fix: linked records dropdown followup #8415

rameshmane7218 commented May 6, 2024

coderabbitai bot commented May 6, 2024 •

edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

github-actions bot commented May 6, 2024 •

edited

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot May 8, 2024

coderabbitai bot May 8, 2024

coderabbitai bot May 8, 2024

		4. To view additional information (expanded record), hover on the card & click on the `<>` icon
		5. Click on the `-` icon to unlink the record

		4. To view additional information (expanded record) before linking, hover on the card & click on the `<>` icon
		5. Click on the `+` icon to link the record

	7. Click on `Link more records` to link an existing record [Read more](#link-new-records)
	7. Click on `Link more records` to link an existing record [Read more](#link-new-records)

Nc fix: linked records dropdown followup #8415

Nc fix: linked records dropdown followup #8415

Conversation

rameshmane7218 commented May 6, 2024

Change Summary

Change type

Test/ Verification

Additional information / screenshots (optional)

coderabbitai bot commented May 6, 2024 • edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 6, 2024 • edited

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot May 8, 2024

Choose a reason for hiding this comment

coderabbitai bot May 8, 2024

Choose a reason for hiding this comment

coderabbitai bot May 8, 2024

Choose a reason for hiding this comment

coderabbitai bot commented May 6, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

github-actions bot commented May 6, 2024 •

edited