fix: add one to one relation in ERD diagram

[dstala]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

Walkthrough

Walkthrough

The recent updates involve enhancing the user interface and functionality of the nc-gui project. Changes include the addition of conditional rendering in the RelationEdge.vue component to differentiate between one-to-one and other relationship types. In utils.ts, the handling of relationship types has been refined with updated enums and logic. Additionally, minor formatting corrections were made in the useViewFilters function for better code clarity.

Changes

File Path	Change Summary
.../components/erd/RelationEdge.vue	Added conditional rendering for a circle element based on the isOneToOne property. If true, a circle is displayed; otherwise, a rectangle.
.../components/erd/utils.ts	Updated relationship type handling with RelationTypes enum, added isOneToOne property, and refined edge label logic.
.../composables/useViewFilters.ts	Corrected spacing around the ternary operator in the logical_op setting.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 448973c and 6732eaf.

Files selected for processing (3)

• packages/nc-gui/components/erd/RelationEdge.vue (1 hunks)
• packages/nc-gui/components/erd/utils.ts (8 hunks)
• packages/nc-gui/composables/useViewFilters.ts (1 hunks)

Files not reviewed due to errors (1)

• packages/nc-gui/components/erd/utils.ts (no review received)

Files skipped from review due to trivial changes (1)

• packages/nc-gui/composables/useViewFilters.ts

Additional comments not posted (1)

packages/nc-gui/components/erd/RelationEdge.vue (1)

120-130: Conditional rendering logic for one-to-one relationships looks correct.

Please verify the positioning of the circle and rectangle in the ERD diagram to ensure they are correctly placed.

Verification successful

---

The review of the RelationEdge.vue file shows that the conditional rendering and positioning logic for the circle and rectangle based on the relationship type appears correct. The circle and rectangle are positioned using coordinates passed to the component, which should align correctly in the ERD diagram if these coordinates are accurately calculated and passed from elsewhere in the application.

• The circle for one-to-one relationships is positioned at (sourceX, sourceY).
• The rectangle for many-to-many relationships is positioned at (targetX, targetY).

Please ensure that the coordinates (sourceX, sourceY, targetX, targetY) are calculated and passed correctly in the context of the entire application to maintain accurate positioning in the ERD diagram.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the positioning of the circle and rectangle in the ERD diagram.

# Test: Search for the component usage in the project. Expect: Correct positioning in the ERD diagram.
rg --type vue $'RelationEdge.vue'

Length of output: 60

---

---

Script:

#!/bin/bash
# Description: Find and display the contents of RelationEdge.vue to verify the integration and usage in the ERD diagram.

# Find the file 'RelationEdge.vue' in the repository
fd RelationEdge.vue --exec cat {}

Length of output: 4354