Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nc feat/filter UI #8429

Merged
merged 23 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9fef4b9
feat: hide arrow if it's in readonly mode
pranavxc May 18, 2024
9434b2a
fix: apply locking logic with filter group
pranavxc May 18, 2024
2a86996
fix: remove border and padding between filter options
pranavxc May 18, 2024
fcc2b31
fix: spacing and font-size corrections
pranavxc May 18, 2024
0357aaa
fix: missing separator line
pranavxc May 18, 2024
3587097
feat: use different background in each level
pranavxc May 18, 2024
044f205
feat: remove border for `where` label
pranavxc May 18, 2024
11f9b5c
feat: keep border for `where` label
pranavxc May 18, 2024
e0d31be
feat: filter ui
pranavxc May 18, 2024
d54ce84
refactor: update spacing
pranavxc May 18, 2024
724420e
feat: suggested ui changes
pranavxc May 18, 2024
b0f238a
fix: disabled text color correction
pranavxc May 18, 2024
3af81e9
feat: focus add button by default and on reopening
pranavxc May 18, 2024
3b6151c
test: fix filter group tests
dstala May 18, 2024
34ecb94
fix: typo correction
pranavxc May 18, 2024
f2ec26b
refactor: spacing and height correction
pranavxc May 18, 2024
e2baed6
refactor: set darker border color to make visible in inner most group
pranavxc May 18, 2024
46b0702
refactor: font color and column order
pranavxc May 18, 2024
e3f6334
fix: filter sql error
dstala May 18, 2024
414b2cc
Update packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCom…
pranavxc May 20, 2024
0342d06
Update tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
pranavxc May 20, 2024
d92d98c
refactor: improved version for focusing button
pranavxc May 20, 2024
6f016b5
refactor: replace button with menuitem
pranavxc May 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view