Downgrade sqlite version while building executables #8435
Conversation
Signed-off-by: Pranav C <pranavxc@gmail.com>
WalkthroughWalkthroughThe changes involve the addition of a script and a command in the GitHub workflow to specifically downgrade the Changes
Assessment against linked issues
The changes made in the PR directly address the issue of executable build failures due to the incompatibility of the latest Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
.github/workflows/release-executables.yml (2)
Line range hint
69-104: Security risk due to variable interpolation withgithubcontext data.- npm i -E nocodb@${{ github.event.inputs.tag || inputs.tag }} + npm i -E nocodb@"$TAG" - # Install nocodb version based on provided tag name + # Install nocodb version based on provided tag name, ensuring safe handling of user inputTo mitigate potential security risks associated with code injection, replace direct interpolation of
githubcontext data with an environment variable that is properly sanitized and quoted. This change should be applied to all instances within this script block.
Line range hint
187-212: Security risk due to variable interpolation withgithubcontext data in Homebrew formula generation.- url "https://github.com/nocodb/nocodb/releases/download/${{ github.event.inputs.tag || inputs.tag }}/nocodb.tar.gz" + url "https://github.com/nocodb/nocodb/releases/download/$TAG/nocodb.tar.gz" - sha256 "${{ steps.compress.outputs.CHECKSUM }}" + sha256 "$CHECKSUM" - version "${{ github.event.inputs.tag || inputs.tag }}" + version "$TAG"To prevent potential security risks from code injection, replace direct interpolation of
githubcontext data with environment variables that are properly sanitized and quoted. This change should be applied to all instances within this script block.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/release-executables.yml (1 hunks)
- scripts/downgradeSqlite.js (1 hunks)
Files skipped from review due to trivial changes (1)
- scripts/downgradeSqlite.js
Change Summary
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of