fix: avoid focus to rich text unless it is expanded

[dstala]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

Walkthrough

Walkthrough

The recent update involves enhancements to the RichText.vue component within the nc-gui package. The primary changes include the addition of a fullMode prop, a switch from using watch to onMounted for initializing the editor, and adjustments to the editor's focus timing dependent on the fullMode and specific form conditions. These modifications aim to optimize editor behavior and user interaction based on the operational mode.

Changes

File Path	Summary of Changes
.../components/cell/RichText.vue	- Added fullMode prop. - Switched from watch to onMounted for editor initialization. - Modified focus timing based on fullMode and form conditions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5be970b and 57a8341.

Files selected for processing (1)

• packages/nc-gui/components/cell/RichText.vue (2 hunks)

Additional comments not posted (2)

packages/nc-gui/components/cell/RichText.vue (2)

222-231: The changes in the onMounted lifecycle hook correctly implement the conditional initialization and focusing of the editor based on the fullMode prop.

Verification successful

---

The search results from the RichText.vue file indicate multiple references to "focus" related to the rich text editor component. These references include properties, method calls, and event handling related to focus management. Here's a breakdown of the findings:

1. Properties and Emits: The component has an autofocus property and emits focus-related events (focus, blur). This suggests that the component is designed to handle focus explicitly.

2. Method Calls: There are multiple calls to editor.value?.chain().focus().run(), which are likely part of the logic to programmatically focus the editor. This aligns with the code snippet provided in the review, where the editor is focused conditionally based on the fullMode value and other conditions.

3. Event Handling: The component has handlers and CSS related to focus, such as @focus="onFocusWrapper" and CSS classes that modify style on focus. This indicates that focus behavior is an integral part of the component's functionality.

Given these findings, the focus management code in the onMounted hook, as described in the review comment, appears to be consistent with other parts of the file. The focus behavior is extensively integrated into the component, suggesting that the implementation in the onMounted hook is likely correct and intended.

Final Response

The focus management implementation in the onMounted hook of the RichText.vue file is consistent with the overall handling of focus within the component. The references found in the file support the use of focus-related methods and properties as intended in the reviewed code snippet.

• The component handles focus events and has properties related to focus management.
• The use of editor.value?.chain().focus().run() is aligned with other parts of the component, confirming that the focus behavior is a deliberate part of the component's functionality.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the focus behavior of the rich text editor is consistent across different scenarios.

# Test: Check for any reported issues related to focus management in the rich text component.
rg --type vue "focus" "packages/nc-gui/components/cell/RichText.vue"

Length of output: 94

---

---

Script:

#!/bin/bash
# Description: Re-verify the focus behavior of the rich text editor by searching for occurrences of "focus" in the RichText.vue file.

# Corrected Test: Search for any reported issues or mentions related to focus management in the rich text component.
rg "focus" "packages/nc-gui/components/cell/RichText.vue"

Length of output: 518

---

35-35: The destructuring of props using toRefs is correctly implemented, enhancing the component's reactivity and maintainability.

[github-actions]

Uffizzi Preview deployment-51503 was deleted.