-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nc fix/form view bug fixes #8498
Conversation
WalkthroughWalkthroughThe recent updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (5)
- packages/nc-gui/components/smartsheet/Form.vue (1 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
Additional comments not posted (9)
packages/nc-gui/utils/formValidations.ts (3)
67-86
: LGTM! The function correctly handles various types of values to determine if they are required.
88-96
: LGTM! The function correctly handles different validation types to determine if they are empty.
Line range hint
97-164
: LGTM! The function correctly adds validators based on the column type and meta properties.packages/nc-gui/composables/useFormViewStore.ts (3)
Line range hint
1-50
: LGTM! The setup of form state and computed properties is correct and follows best practices.
51-68
: LGTM! The validation logic correctly handles required fields and additional validators.
Line range hint
69-164
: LGTM! The form submission and update logic is correct and follows best practices.packages/nc-gui/composables/useSharedFormViewStore.ts (3)
Line range hint
1-196
: LGTM! The setup of shared form state and computed properties is correct and follows best practices.
197-218
: LGTM! The validation logic correctly handles required fields and additional validators.
Line range hint
219-464
: LGTM! The form submission and update logic is correct and follows best practices.
Uffizzi Preview |
32f7920
to
7482820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (5)
- packages/nc-gui/components/smartsheet/Form.vue (1 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
f59d1c4
to
1ff2d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/smartsheet/Form.vue (4 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/windi.config.ts
Files skipped from review as they are similar to previous changes (5)
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/smartsheet/Form.vue (4 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
- packages/nc-gui/windi.config.ts
1ff2d13
to
7306760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/smartsheet/Form.vue (4 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
- packages/nc-gui/windi.config.ts
7306760
to
238db15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/smartsheet/Form.vue (4 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
- packages/nc-gui/windi.config.ts
238db15
to
4251336
Compare
4251336
to
87e8810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/smartsheet/Form.vue (4 hunks)
- packages/nc-gui/components/smartsheet/form/field-settings.vue (2 hunks)
- packages/nc-gui/composables/useFormViewStore.ts (1 hunks)
- packages/nc-gui/composables/useSharedFormViewStore.ts (1 hunks)
- packages/nc-gui/utils/formValidations.ts (1 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/smartsheet/Form.vue
- packages/nc-gui/components/smartsheet/form/field-settings.vue
- packages/nc-gui/composables/useFormViewStore.ts
- packages/nc-gui/composables/useSharedFormViewStore.ts
- packages/nc-gui/utils/formValidations.ts
- packages/nc-gui/windi.config.ts
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of