refactor: show unsupported formula functions as disabled

[dstala]

Change Summary

Provide summary of changes with issue number if any.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[coderabbitai]

Walkthrough

Walkthrough

The recent updates focus on enhancing the handling of unsupported functions within formula suggestions and validation processes. These changes ensure that unsupported functions are clearly identified and appropriately managed in both the frontend (GUI) and backend (SDK). The GUI now visually distinguishes unsupported functions and adjusts user interactions accordingly, while the SDK includes logic to handle unsupported functions during formula validation.

Changes

Files/Paths	Change Summary
packages/nc-gui/components/smartsheet/column/FormulaOptions.vue	Modified suggestionsList to include an unsupported property, sorted unsupported functions to the end, and updated template logic and styling for unsupported items. Enhanced handleInput() and selectText() functions to skip unsupported formulas.
packages/nocodb-sdk/src/lib/formulaHelpers.ts	Updated validateFormulaAndExtractTreeWithType function to handle unsupported functions in sqlUI.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c7cc1f9 and 36b2e20.

Files ignored due to path filters (1)

• packages/nc-gui/lang/en.json is excluded by !**/*.json

Files selected for processing (2)

• packages/nc-gui/components/smartsheet/column/FormulaOptions.vue (4 hunks)
• packages/nocodb-sdk/src/lib/formulaHelpers.ts (1 hunks)

Additional comments not posted (3)

packages/nc-gui/components/smartsheet/column/FormulaOptions.vue (3)

105-145: Refactor suggestionsList to handle unsupported functions effectively.

This change effectively segregates supported and unsupported functions, ensuring that unsupported functions are moved to the end of the suggestions list. This aligns with the PR's objective to show unsupported formula functions as disabled.

---

228-228: Ensure unsupported formulas are not appended.

The modification to skip appending unsupported formulas when selected is a crucial enhancement for usability, preventing users from selecting formulas that are not supported in the current context.

---

291-291: Enhance UI feedback for unsupported formulas.

The changes in the template to conditionally render styles and behaviors for unsupported formulas enhance user experience by clearly indicating which formulas can and cannot be used.

Also applies to: 372-372, 374-374, 379-387

[github-actions]

Uffizzi Preview deployment-51949 was deleted.