Skip to content

Commit

Permalink
Fix hip dynamic_symbols_test to check min version. (iree-org#17674)
Browse files Browse the repository at this point in the history
Progress on iree-org#17370

ci-exactly: build_all, test_amd_mi250
  • Loading branch information
ScottTodd committed Jun 15, 2024
1 parent c5d4b96 commit 1ea21d1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,11 @@ TEST(NCCLDynamicSymbolsTest, CreateFromSystemLoader) {
GTEST_SKIP() << "HIP RCCL symbols cannot be loaded, skipping test.";
}

// Check that the loaded version is at least the version we compiled for.
int nccl_version = 0;
NCCL_CHECK_ERRORS(nccl_symbols.ncclGetVersion(&nccl_version));
ASSERT_EQ(NCCL_VERSION_CODE, nccl_version);
ASSERT_GE(nccl_version, NCCL_VERSION_CODE);

iree_hal_hip_nccl_dynamic_symbols_deinitialize(&nccl_symbols);
iree_hal_hip_dynamic_symbols_deinitialize(&hip_symbols);
}
Expand Down

0 comments on commit 1ea21d1

Please sign in to comment.