Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#115] Refactor: 메인페이지 관련 리팩토링 #119

Merged
merged 7 commits into from
Jun 21, 2024

Conversation

ienrum
Copy link
Collaborator

@ienrum ienrum commented Jun 19, 2024

💬 Issue Number

closes #115

🤷‍♂️ Description

작업 내용에 대한 설명

  • GET, postList api 함수 리팩토링
  • channel -> categoryId 해주는 유틸 맵 제거
  • ChipContainer link 라우팅시 /?channel=all/ 로 변경
  • query 파라미터인 channel 에 따라, chip 컴포넌트 selected 결정되게 수정

📷 Screenshots

작업 결과물

👻 Good Function

팀원에게 공유하고 싶은 함수나 코드 일부

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

@ienrum ienrum added the 🔨 Refactor 코드 리팩토링 label Jun 19, 2024
@ienrum ienrum self-assigned this Jun 19, 2024
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-egtfyznbbf.chromatic.com/

@HoberMin HoberMin force-pushed the #115/refactor/main-page/chae branch from f74d266 to e08e1e3 Compare June 21, 2024 14:34
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-vfvzkgahpx.chromatic.com/

Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-tfjjgouqfy.chromatic.com/

@HoberMin HoberMin merged commit 67467ea into main Jun 21, 2024
3 checks passed
@HoberMin HoberMin deleted the #115/refactor/main-page/chae branch June 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] 메인페이지 리팩토링 및 라우팅 수정
2 participants