-
Notifications
You must be signed in to change notification settings - Fork 342
Parse error, ZonedDateTime #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting this. I'll look into it tomorrow. using System;
using NodaTime;
using NodaTime.Text;
class Test
{
static void Main()
{
var pattern = ZonedDateTimePattern.ExtendedFormatOnlyIso
.WithZoneProvider(DateTimeZoneProviders.Tzdb);
var value = pattern.Parse("1906-08-29T20:58:32 Etc/GMT-12 (+12)").Value;
}
} This fails in NodaTime 2.2.0 with regular .NET on Windows. (Once I've found the bug, I'll need to work out whether or not to backport the fix to the 1.4 series.) |
(I suspect the problem is that GMT-1 is a valid time zone ID, so it thinks that's the time zone. This may be somewhat painful to fix... we'll see.) |
We were previously stopping too early in the search. Fixes nodatime#981. Should probably be backported to 1.4.x and 2.2.x.
Closing for the development branch, but will probably backport to 1.4.x and 2.2.x |
We were previously stopping too early in the search. Fixes nodatime#981. Should probably be backported to 1.4.x and 2.2.x.
We were previously stopping too early in the search. Fixes #981. Should probably be backported to 1.4.x and 2.2.x.
This is a cherry-pick of f78a32a for the 1.4 branch. Fixes nodatime#981.
We were previously stopping too early in the search. Fixes nodatime#981. (Cherry-picked from f78a32a)
We were previously stopping too early in the search. Fixes nodatime#981. (Cherry-picked from f78a32a)
This is a cherry-pick of f78a32a for the 1.4 branch. Fixes nodatime#981.
This is a cherry-pick of f78a32a for the 1.4 branch. Fixes nodatime#981.
This test fails:
With this error message:
The value was generated thus:
Version of things:
macOS 10.12.6, mono 5.2.0.215, NodaTime 1.4
More failing test strings:
The value string does not match a simple character in the format string " ". Value being parsed: '1994-02-09T09:02:33 Etc/GMT-1^1 (+11)'. (^ indicates error position.)
The text was updated successfully, but these errors were encountered: