-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config.schema.json for UI-X settings support #36
Add config.schema.json for UI-X settings support #36
Conversation
config.schema.json as proposed is not complete. "armingModes" is not included. Optional elements "authTimeoutMinutes" and "pollTimeoutSeconds" are also not included. I am looking at implementing these elements. |
@DMBlakeley Yeah, I didn't intend to add all of them right away. You can still add them the usual way even with this. But feel free to add them yourself. It shouldn't block merging this, though, IMO. |
I recently submitted a config.schema.json implementation for Poking around a bit I found that "platform" in the config.json file needed to be Also, can you clarify if Arming Modes are required or optional? |
Further update ... "platform" in the config.json file and "pluginAlias" in the schema file need to match. As the README.md file states "Alarmdotcom" just change "pluinAlias" to match and all is good. Also, do see that Arming Modes have default values and as a result are optional. |
Done. Did that end up being the only change needed? |
Yes, for the required parameters to work. |
I'm not ready to pull this into the main repo yet, I am waiting for one of the people I am testing the lights configuration to get back from being out of town and then I can test the changes I have made to fix that issue first before adding this. Plus there are a couple of other changes that need to be grouped with this implementation so it will be verified as working with Config UI X. |
As documented here: https://github.com/oznu/homebridge-config-ui-x/wiki/Developers%3A-Plugin-Settings-GUI