Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.schema.json for UI-X settings support #36

Merged
merged 3 commits into from
May 8, 2020
Merged

Add config.schema.json for UI-X settings support #36

merged 3 commits into from
May 8, 2020

Conversation

cap10morgan
Copy link

@DMBlakeley
Copy link

config.schema.json as proposed is not complete. "armingModes" is not included. Optional elements "authTimeoutMinutes" and "pollTimeoutSeconds" are also not included.

I am looking at implementing these elements.

@cap10morgan
Copy link
Author

@DMBlakeley Yeah, I didn't intend to add all of them right away. You can still add them the usual way even with this. But feel free to add them yourself. It shouldn't block merging this, though, IMO.

@DMBlakeley
Copy link

DMBlakeley commented May 5, 2020

I recently submitted a config.schema.json implementation for homebridge-awair for consideration. When I did the Awair implementation, the interface picked up config values that already existed in config.json. This was not the case with the homebridge-node-alarm-dot-com version.

Poking around a bit I found that "platform" in the config.json file needed to be "platform": "AlarmDotCom" rather than "platform": "Alarmdotcom" as stated in the README.md file. The first line of the schema file also needs to match (no spaces). These changes should probably be made also.

Also, can you clarify if Arming Modes are required or optional?

@DMBlakeley
Copy link

DMBlakeley commented May 5, 2020

Further update ...

"platform" in the config.json file and "pluginAlias" in the schema file need to match. As the README.md file states "Alarmdotcom" just change "pluinAlias" to match and all is good.

Also, do see that Arming Modes have default values and as a result are optional.

@cap10morgan
Copy link
Author

just change "pluinAlias" to match and all is good

Done. Did that end up being the only change needed?

@DMBlakeley
Copy link

Yes, for the required parameters to work.

@mkormendy
Copy link
Collaborator

I'm not ready to pull this into the main repo yet, I am waiting for one of the people I am testing the lights configuration to get back from being out of town and then I can test the changes I have made to fix that issue first before adding this. Plus there are a couple of other changes that need to be grouped with this implementation so it will be verified as working with Config UI X.

@mkormendy mkormendy merged commit 270c507 into node-alarm-dot-com:master May 8, 2020
@cap10morgan cap10morgan deleted the feature/config-schema branch May 11, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants