Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connection.js to support a "shutdown" command #134

Closed
wants to merge 3 commits into from
Closed

Update connection.js to support a "shutdown" command #134

wants to merge 3 commits into from

Commits on Oct 30, 2013

  1. Update connection.js to support a "shutdown" command 

    This change adds a shutdown method that indicates to socketDrained that it should close connections once there are no more notifications to send. The side effect is that the node process will end. I've tested the change both with all successful messages, as well as when a few messages can't be sent. In both cases, the program does not shutdown until all messages that can be successfully sent our sent.
    @ejc3
    ejc3 committed Oct 30, 2013
    Copy the full SHA
    212697a View commit details
    Browse the repository at this point in the history

  2. cleaned up extra param

    @ejc3
    ejc3 committed Oct 30, 2013
    Copy the full SHA
    5774706 View commit details
    Browse the repository at this point in the history

  3. Update connection.js 

    fix spelling mistake
    @ejc3
    ejc3 committed Oct 30, 2013
    Copy the full SHA
    4c7c3ca View commit details
    Browse the repository at this point in the history