Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flush stats): flush stats method #161

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

sujeshthekkepatt
Copy link
Contributor

Currently no method to flush the stats.
Flushing stats helpful for metrics analysis. See more #158

Currently no method to flush the stats.
Flushing stats helpful for metrics analysis. See more node-cache#158
@sujeshthekkepatt
Copy link
Contributor Author

@erdii please take a look

Copy link
Member

@erdii erdii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pr @sujeshthekkepatt! thanks for also updating the docs <3

I have added 2 change requests

_src/lib/node_cache.coffee Show resolved Hide resolved
_src/test/mocha_test.coffee Show resolved Hide resolved
@erdii
Copy link
Member

erdii commented Dec 8, 2019

wait nevermind! i'll just merge it and add the changes myself. Then I can create a new release with t his and .take() from #160

@erdii erdii merged commit 66cb56a into node-cache:master Dec 8, 2019
erdii added a commit that referenced this pull request Dec 8, 2019
@erdii erdii mentioned this pull request Dec 8, 2019
@sujeshthekkepatt sujeshthekkepatt deleted the feat/flushstats branch December 8, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants