Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install TypeScript as part of devDependencies #39

Closed
fdionisi opened this issue Apr 23, 2021 · 3 comments · Fixed by #41
Closed

Install TypeScript as part of devDependencies #39

fdionisi opened this issue Apr 23, 2021 · 3 comments · Fixed by #41
Assignees
@hsluoyz
Labels
bug Something isn't working released

Comments

@fdionisi
Copy link
Contributor

fdionisi commented Apr 23, 2021 •
edited by hsluoyz
Loading

Looking at the package.json, I noticed that the TypeScript npm package is installed as a direct dependency.

mongoose-adapter/package.json

Lines 81 to 86 in dca7419

"dependencies": {
"@types/mongodb": "^3.6.11",
"mongodb": "^3.6.5",
"mongoose": "^5.12.3",
"typescript": "^4.2.3"
},

This means that every production installations of software depending on casbin-mongoose-adapter will have an often superfluous module, making node_modules/ a little bit bigger.

I suggest moving TypeScript dependency to devDependencies instead.

Before opening a PR, I wanted to ensure there is no hidden reason behind your initial decision.
@hsluoyz
Copy link
Member

hsluoyz commented Apr 23, 2021

@Zxilly @Sefriol

@hsluoyz hsluoyz self-assigned this Apr 23, 2021
@hsluoyz hsluoyz added the question Further information is requested label Apr 23, 2021
@Zxilly
Copy link
Contributor

Zxilly commented Apr 23, 2021 •
edited
Loading

@fdionisi Yes, you are right. PR is welcome.

@hsluoyz hsluoyz added bug Something isn't working and removed question Further information is requested labels Apr 23, 2021
@fdionisi fdionisi mentioned this issue Apr 23, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move TypeScirpt to devDependencies fdionisi/mongoose-adapter
3 participants
@hsluoyz @fdionisi @Zxilly