Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a CasbinMongoRule to properly work with MongoDB #18

Merged
merged 2 commits into from Dec 12, 2019

Conversation

fchristl
Copy link
Contributor

Added a CasbinMongoRule to properly work with MongoDB

Also, added generic types for CasbinRule | CasbinMongoRule in adapter and
methods to load the correct rule, depending on the connection type.

- Added generic types for `CasbinRule | CasbinMongoRule` in adapter and
methods to load the correct rule, depending on the connection type.
@fchristl
Copy link
Contributor Author

(Addresses #17)

@coveralls
Copy link

coveralls commented Dec 12, 2019

Pull Request Test Coverage Report for Build 31

  • 22 of 25 (88.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.1%) to 61.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adapter.ts 12 15 80.0%
Totals Coverage Status
Change from base Build 29: 3.1%
Covered Lines: 75
Relevant Lines: 95

💛 - Coveralls

@hsluoyz
Copy link
Member

hsluoyz commented Dec 12, 2019

lgtm

@hsluoyz hsluoyz merged commit 74ea39d into node-casbin:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants