Fix empty YAML file causing crash with latest js-yaml #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/config.js
lorenwest
added a commit
that referenced
this pull request
Jul 22, 2014
Fix empty YAML file causing crash with latest js-yaml
|
Thank you for this update. It comes very timely as I intend to publish 1.0 to NPM later today. I will also merge this change into the 0.4 branch so those not wishing to upgrade to 1.0 can benefit. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracking configuration sources, an assumption is made that
configObjectis going to always be an object. With the latest js-yaml, this assumption is no longer true, as an empty YAML file will returnundefinedwhen parsed.Attempting to serialize
undefinedinto a JSON string by usingJSON.stringify()is legal, also returningundefined. However, attempting to get thelengthproperty ofundefinedis an error.This request eliminates this assumption by ensuring that configObject is actually an object before attempting to get the length of the serialized object.