Yaml switch #24
Merged
Yaml switch #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added tests for it.
The nodeca parser is a lot more elaborate and stable.
|
Ok.. So I added the Visionmedia YAML parser as fallback if the nodeca parser isn't available. I haven't found a better way than to simply catch the |
|
Is there any reason you didn't pull this in yet? Are you not convinced that nodeca's yaml parser is better? Or is there something wrong with my request? |
|
Apologies for taking so long to merge this. I'll get a new version published to npm shortly. |
|
No problem! I have pending pull requests for weeks sometimes before I have the time to merge them. I just wanted to make sure that everything was OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, as requested, a separate pull request for the yaml parser switch.
I agree with you: it shouldn't break existing users. At the same time: The other yaml parser is just.. better. So if users switch to it, they shouldn't have any problems with their
.yamlfiles.The only thing they have to do, is to install the other yaml parser.
If you want I can check if there's a nice way to check if either of the yaml modules is installed, thus not braking backwards compatibility.
PS.: I based this pull request on the other one, since you said you wanted to pull it in anyway.