Fixes #240. Edge case when dealing with multiple ranges for one parameter of the cron input #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discussed the issue in #240
Essentially, if the
g
flag is removed from the replace function, we make sure to only replace the first instance of the expression to be replaced. This is okay since the while loop will run again if there's other ranges to be converted.Since the original regex finds the first instance of the range, this replace will only replace the first instance.
Hence, fixes the edge case of replacing an incorrect sub-string, and also will not change the functionality.