Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/drop moment #20

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Feat/drop moment #20

merged 3 commits into from
Nov 6, 2019

Conversation

nanov
Copy link
Contributor

@nanov nanov commented Nov 6, 2019

#17

@nanov nanov merged commit d21d89f into master Nov 6, 2019
@Herrie82
Copy link
Contributor

@nanov Any specific reason to drop the moment.js requirement? I can see cases where it would be useful to have in the various scripts to send instructions with start and end-dates. For example to pull the statements from previous business day would be a lot more straight forward if we would use something like: https://www.npmjs.com/package/moment-business-days

@nanov
Copy link
Contributor Author

nanov commented Nov 26, 2019

Well, I personally thing this is an unneeded dependency of the client by-itself one may choose to use whatever he likes on his side.

With that being said, the library could benefit from utils like the one you described, and they are pretty straight forward to write in plain ( modern ) javascript and would be a good addition. Let's open a separate issue and discuss the API plus implementation details so we can get this rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants