Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until the keys are generated #33

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Wait until the keys are generated #33

merged 1 commit into from
Mar 6, 2020

Conversation

chrwoizi
Copy link
Contributor

@chrwoizi chrwoizi commented Mar 4, 2020

The initialization method should wait until the key file is written because other methods could use the keys-method after initialization.

The initialization method should wait until the key file is written because other methods could use the keys-method after initialization.
@nanov
Copy link
Contributor

nanov commented Mar 5, 2020

Agreed!

Great catch!
I will merge and release later on today!

@nanov nanov merged commit 99f0bd9 into node-ebics:master Mar 6, 2020
@nanov
Copy link
Contributor

nanov commented Mar 6, 2020

Landed in v0.1.5 - i took the liberty to add you to contributors list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants