Support JSON5 #12
Merged
Support JSON5 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 26, 2017 03:26
qfox
reviewed
Mar 26, 2017
| var path = require('path'); | ||
|
|
||
| var nodeEval = require('node-eval'); | ||
| var JSON5 = require('json5'); |
There was a problem hiding this comment.
What is faster, vm.runInThisContext or JSON5.parse?
There was a problem hiding this comment.
Run in 100000 files
| Format | Real time | User Time | Sys Time |
|---|---|---|---|
| CommonJS | 4.237s | 3.709s | 1.359s |
| JSON | 4.240s | 3.724s | 1.367s |
| JSON 5 | 4.444s | 3.912s | 1.401s |
There was a problem hiding this comment.
Ты воздух гонял, ты это знаешь?
birhoff
approved these changes
Mar 26, 2017
blond
force-pushed
the
issue-11
branch
2 times, most recently
from
6d4f4e9
to
a94e410
Compare
tadatuta
approved these changes
Mar 26, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.