-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Node.js v12 #98
Comments
`fetch-blob` v3 doesn’t support Node.js v12, see: node-fetch/fetch-blob#98 .
We made the decision to ditch commonjs for ESM. Guess we wasn't so thoughtful of selecting the right node versions. We have a PR in node fetch that changed the engine to "node": "^12.20.0 || ^14.13.1 || >=16.0.0" Maybe should select the same range since that is all version that support ESM Willing to make PR and change package.json to those version? |
|
That's fine then maybe this can work? |
You forgot the |
Currently, only Node.js v14+ is supported:
fetch-blob/package.json
Lines 28 to 30 in 4747497
I didn't realize this when I tried to update to the latest version and ran into problems with optional chaining:
fetch-blob/index.js
Line 198 in 4747497
Many packages at the moment, including all of mine, support Node.js
^12.20 || >= 14.13
. E.g:https://github.com/jaydenseric/apollo-upload-client/blob/e19deb9f1fc950f35a2f652c02135408bbe2a38a/package.json#L43-L45
This range supports most of the important Node.js ESM and package
exports
field features.Until Node.js v12 is EOL we'll be stuck on the last
fetch-blob
version to support it; would you consider expanding the current level of support to accept Node.js^12.20 || >= 14.13
?The text was updated successfully, but these errors were encountered: