chore: remove EventTarget from the isAbortSignal (#1490)

BREAKING CHANGE: when checking if something is a AbortSignal we no longer check if name match EventTarget
node-fetch · Jan 27, 2022 · fcd8bdd · fcd8bdd
1 parent 1c775f1
commit fcd8bdd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/utils/is.js b/src/utils/is.js
@@ -49,12 +49,7 @@ export const isBlob = object => {
  * @return {boolean}
  */
 export const isAbortSignal = object => {
-	return (
-		typeof object === 'object' && (
-			object[NAME] === 'AbortSignal' ||
-			object[NAME] === 'EventTarget'
-		)
-	);
+	return object?.[NAME] === 'AbortSignal';
 };
 
 /**

diff --git a/test/main.js b/test/main.js
@@ -1206,11 +1206,11 @@ describe('node-fetch', () => {
 
 	testAbortController('mysticatea', () => new AbortControllerMysticatea());
 
-	if (process.version > 'v15') {
-		testAbortController('native', () => new AbortController());
+	if (globalThis.AbortController) {
+		testAbortController('native', () => new globalThis.AbortController());
 	}
 
-	it('should throw a TypeError if a signal is not of type AbortSignal or EventTarget', () => {
+	it('should throw a TypeError if a signal is not of type AbortSignal', () => {
 		return Promise.all([
 			expect(fetch(`${base}inspect`, {signal: {}}))
 				.to.be.eventually.rejected