TypeError: Invalid URL

[tyanbiao]

Reproduction

Steps to reproduce the behavior:

1. use node-fetch to request url https://r2---sn-n4v7sney.googlevideo.com
2. throw error: TypeError: Invalid URL

You can try to reproduce the issue by running the code below

const fetch = require('node-fetch')

async function getAudio() {
    const ret = await fetch('https://r2---sn-n4v7sney.googlevideo.com')
    const text = await ret.text()
    return text
}

getAudio().catch(e => console.error(e))

Expected behavior

https://r2---sn-n4v7sney.googlevideo.com is a valid url

Screenshots

Your Environment

software	version
node-fetch	2.6.5
node	v14.18.1
npm	6.14.15
Operating System	Windows 10

Additional context

[jimmywarting]

This boils down to:

const whatwg = require('whatwg-url@5')
new whatwg.URL('https://r2---sn-n4v7sney.googlevideo.com') // throws not valid url error

using:

const whatwg = require('whatwg-url@latest')
new whatwg.URL('https://r2---sn-n4v7sney.googlevideo.com') // works fine
new globalThis.URL('https://r2---sn-n4v7sney.googlevideo.com') // also works fine

And we could not use the latest whatwg-url version since v2 still supports node v4
using a older whatwg-url is by no doubt buggy...

Maybe we could rely on the built in node version if available and then fallback to whatwg if it's not available?

changing this to: require('url').URL || whatwgUrl.URL

node-fetch/src/request.js

Line 17 in b5417ae

const URL = whatwgUrl.URL;

This will not actually fix the issue for older node versions, only hide it in newer node versions...

---

fyi, v3 don't have this issue cuz it uses nodes own URL

[jimmywarting]

could you try 2.6.6 if it works now?

[tyanbiao]

could you try 2.6.6 if it works now?

It works fine in version 2.6.6