Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(URL): prefer built in URL version when available and fallback to whatwg #1352

Merged
merged 2 commits into from Oct 31, 2021

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Oct 28, 2021

What is the purpose of this pull request?

  • Bug fix

What changes did you make? (provide an overview)

Use the newest URL instance whenever it's available.

Which issue (if any) does this pull request address?

  • fix #1342 (but only for node v6.13.0 and above)

@jimmywarting jimmywarting requested review from LinusU and gr2m Oct 30, 2021
LinusU
LinusU approved these changes Oct 31, 2021
Copy link
Member

@LinusU LinusU left a comment

Neat 👍

@jimmywarting jimmywarting requested a review from Richienb Oct 31, 2021
gr2m
gr2m approved these changes Oct 31, 2021
@jimmywarting jimmywarting merged commit f56b0c6 into 2.x Oct 31, 2021
@jimmywarting jimmywarting deleted the feature/builtin-URL branch Oct 31, 2021
kodiakhq bot pushed a commit to carbon-design-system/carbon-for-ibm-dotcom-nextjs-template that referenced this issue Nov 16, 2021
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [node-fetch](https://togithub.com/node-fetch/node-fetch) | [`^2.6.1` -> `^2.6.6`](https://renovatebot.com/diffs/npm/node-fetch/2.6.2/2.6.6) | [![age](https://badges.renovateapi.com/packages/npm/node-fetch/2.6.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/node-fetch/2.6.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/node-fetch/2.6.6/compatibility-slim/2.6.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/node-fetch/2.6.6/confidence-slim/2.6.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>node-fetch/node-fetch</summary>

### [`v2.6.6`](https://togithub.com/node-fetch/node-fetch/releases/v2.6.6)

[Compare Source](https://togithub.com/node-fetch/node-fetch/compare/v2.6.5...v2.6.6)

##### What's Changed

-   fix(URL): prefer built in URL version when available and fallback to whatwg by [@&#8203;jimmywarting](https://togithub.com/jimmywarting) in [node-fetch/node-fetch#1352

**Full Changelog**: node-fetch/node-fetch@v2.6.5...v2.6.6

### [`v2.6.5`](https://togithub.com/node-fetch/node-fetch/compare/a41c469c6164e7175f39113c875a9ddd2f064504...v2.6.5)

[Compare Source](https://togithub.com/node-fetch/node-fetch/compare/a41c469c6164e7175f39113c875a9ddd2f064504...v2.6.5)

### [`v2.6.4`](https://togithub.com/node-fetch/node-fetch/compare/v2.6.3...a41c469c6164e7175f39113c875a9ddd2f064504)

[Compare Source](https://togithub.com/node-fetch/node-fetch/compare/v2.6.3...a41c469c6164e7175f39113c875a9ddd2f064504)

### [`v2.6.3`](https://togithub.com/node-fetch/node-fetch/compare/v2.6.2...v2.6.3)

[Compare Source](https://togithub.com/node-fetch/node-fetch/compare/v2.6.2...v2.6.3)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom-nextjs-template).
otc-zuul bot pushed a commit to opentelekomcloud/ui-cluster-driver-otc that referenced this issue Mar 29, 2022
Bump node-fetch from 2.6.1 to 2.6.7

Bumps node-fetch from 2.6.1 to 2.6.7.

Release notes
Sourced from node-fetch's releases.

v2.6.7
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed

fix: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1453

Full Changelog: node-fetch/node-fetch@v2.6.6...v2.6.7
v2.6.6
What's Changed

fix(URL): prefer built in URL version when available and fallback to whatwg by @​jimmywarting in node-fetch/node-fetch#1352

Full Changelog: node-fetch/node-fetch@v2.6.5...v2.6.6
v2.6.2
fixed main path in package.json



Commits

1ef4b56 backport of #1449 (#1453)
8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310)
f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (...
b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303)
18193c5 fix v2.6.3 that did not sending query params (#1301)
ace7536 fix: properly encode url with unicode characters (#1291)
152214c Fix(package.json): Corrected main file path in package.json (#1274)
See full diff in compare view



Maintainer changes
This version was pushed to npm by endless, a new releaser for node-fetch since your current version.



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Reviewed-by: Anton Kachurin <katchuring@gmail.com>
otc-zuul bot pushed a commit to opentelekomcloud/ui-driver-otc that referenced this issue Apr 12, 2022
Bump node-fetch from 2.6.1 to 2.6.7

Bumps node-fetch from 2.6.1 to 2.6.7.

Release notes
Sourced from node-fetch's releases.

v2.6.7
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed

fix: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1453

Full Changelog: node-fetch/node-fetch@v2.6.6...v2.6.7
v2.6.6
What's Changed

fix(URL): prefer built in URL version when available and fallback to whatwg by @​jimmywarting in node-fetch/node-fetch#1352

Full Changelog: node-fetch/node-fetch@v2.6.5...v2.6.6
v2.6.2
fixed main path in package.json



Commits

1ef4b56 backport of #1449 (#1453)
8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310)
f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (...
b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303)
18193c5 fix v2.6.3 that did not sending query params (#1301)
ace7536 fix: properly encode url with unicode characters (#1291)
152214c Fix(package.json): Corrected main file path in package.json (#1274)
See full diff in compare view



Maintainer changes
This version was pushed to npm by endless, a new releaser for node-fetch since your current version.



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Reviewed-by: Anton Kachurin <katchuring@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants