Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove EventTarget from the isAbortSignal #1490

Merged
merged 2 commits into from Jan 27, 2022
Merged

chore: remove EventTarget from the isAbortSignal #1490

merged 2 commits into from Jan 27, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 27, 2022 •
edited

Purpose

should not check if a AbortSignal is of type EventTarget

Changes

Additional information

  • I updated readme
  • I changed unit test description

@jimmywarting jimmywarting added this to the Version 4.0.0 milestone Jan 27, 2022
gr2m
gr2m approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in #1484, make sure to describe the breaking change so we can keep track

@jimmywarting jimmywarting merged commit fcd8bdd into node-fetch:beta Jan 27, 2022
@jimmywarting jimmywarting deleted the no-emitter branch January 27, 2022 22:42
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@LinusU LinusU Awaiting requested review from LinusU

Assignees
No one assigned
Labels
released on @beta v4
Projects
None yet
Milestone
Version 4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimmywarting @gr2m