-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce linting to the project #303
Comments
Sounds fine to me. I've used Airbnb before with good experiences as well, though I wouldn't mind xo either. |
I am kinda against it, and my main reasoning:
But I do agree eventually |
I have always hated it, never dose what I want. My principle is only:
Otherwise you add more complexity, dependencies, compile time, researching "what is wrong with my code, how to make linters happy" and sending new bug reports to something that is wrong or not supported like when the new async/await came for example But i must admit, Linters is a good tool for the quality of your code. but you must put some more effort into it. But to me it's not worth it |
Ok, everyone seems to be split on this :) Putting it on hold for now and can revisit in the future |
Can stick prettier in there instead of full eslint? Pretty easy win in my eyes |
@SimenB IMO it's more the other stuff that's useful, like |
have not been a fan of xo due to it's size and taking long time to install, adds 100mb of data and 644 packages. Sometimes i worry what i'm installing without knowing what goes into a package
npm ls
|
@bitinn, @TimothyGu
Mostly in an effort to stop myself from committing things missing semi's (I work on a lot of no semi projects, heh) I think it might be advantageous to set up linting.
There are already a bunch of different styles being used throughout the code but this is mostly auto-fixable using modern tooling. My suggestion:
eslint
dev depeslint-config-airbnb-base
preset dev depThis would configure linting to the Airbnb style guide, which is very common (especially among front end packages), and can be read here: https://github.com/airbnb/javascript
Advantages:
After we have all rules implemented/agreed on over some time, we could then also:
Thoughts?
The text was updated successfully, but these errors were encountered: