add transparent http2

[devsnek]

mvp for http2 support (experimental and dangerous, don't complain if this deletes your cat pictures)

since http2 features and support have been gradually added through node 9.x, it would seem that this feature might need to be explicitly locked to node >= 10

todo

• use Http2ClientSession for redirects within the same origin instead of creating a new one
• tests

[gr2m]

@devsnek Hey Gus, I’m no maintainer of node-fetch but several other projects out there, some of which depend on node-fetch and I know some of the maintainers personally. I’m sure everyone appreciates that you take time to contribute. I would find your language unnecessary confrontational though. It would be reason enough to just ignore your pull request altogether. Open source tends to be a hostile place some times and your PR has lots of red flags.

A lot of people put a lot of time into node-fetch and I’m sure they have reasons for the preference of their code style. You are coming to their house and really should respect their rules ;) You could create a separate issue though with a friendly suggestion to change the code style and offer to help with the migration if the maintainers agree.

I would recommend you close your pull request, remove the eslint configuration, leave all the syntax as-is and only submit a minimal pull request with the changes required for http2. If you like, create an issue to suggest to make changes to the code style and wait for the maintainers think of it. And use kind language, it will help a lot to get maintainers attention, I can tell that from my own experience, both as maintainer and contributor

[devsnek]

@gr2m I'm sorry if you found my words or actions abrasive in any way, I didn't intend it. I simply generated an eslint that kept the diff the smallest while keeping all the code in the library consistent. I also kept it in a separate commit. the issue i found was that i couldn't even figure out even whether to use spaces or indents in the project since different files use different styles.

[bitinn]

the mixed use of tab/space is unfortunately the status quo: some files are taken from nodejs core and thus use spaces while the main project was using tab.

on topic: http/2 support is too large a feature to be taken in a single PR (in browser it's transparent, nodejs it isn't, at least for now; Timothy might persuade nodejs to add a unified interface for http one day); adding eslint is not helping anyone to review this PR hence nobody did...

[devsnek]

@bitinn this adds the feature as transparent using alpn negotiation. I've been messing around with it on my own request lib (I actually use node-fetch to test my lib 😄) and it seems quite stable. as for the eslint stuff I'll delete the commit

[jimmywarting]

Linting is put on hold for the time being #303
Have to agree with everything @gr2m says

[TimothyGu]

As I said in #342, we will need an equivalent of http.Agent to allow us to reuse Http2ClientSessions. This is kind of covered by

use Http2ClientSession for redirects within the same origin instead of creating a new one

only that the pool should be used not just for redirects but also for general purpose. A caveat however, is the connection in the connection pool must be keyed by BOTH origin AND the presence of credentials.

Thus, putting this on hold for now.