fix: handle bom in text and json

[aclarembeau]

Purpose

Bring the fix https://github.com/node-fetch/node-fetch/pull/1482/commits from 3.X to 2.X

Changes

Allow parsing results with BOM encoding

Additional information

It's just a copy paste of the fix of https://github.com/node-fetch/node-fetch/pull/1482/commits for node-fetch 2.X, for the people who can't use 3.X

---

• I updated readme
• I added unit test(s)

---

• fix #000

[smeet666]

I would really love to see this change accepted, I'm in the exact same case where I can't upgrade to 3.0 now but I don't like too much to patch it on my side.

[jimmywarting]

Normally the process have been that at least 2 core members needs to review and accept, if at least 2 agrees then we will merge.
But if it may take to long or nobody have time to review then 1 can be enough.

we also don't do so much in the v2 branch anymore unless it's a security issue.

ping @LinusU

---

I can't upgrade to 3.0

any particular reason why you can't update?
there isn't any problem loading ESM module from CJS
you just have to load it lazily with import('node-fetch').then(...) read more here of how you can load v3

Another suggestion is just to update your nodejs version to v18/20 that have fetch built in, so no dependencies hare needed.

v20 is required if you want to replace the ways you get blob/files backed up by the file system. for instance: fileFromAsync(path) -> fs.openAsBlob(path)

[LinusU]

Neat! 👍

[github-actions]

🎉 This PR is included in version 2.6.10 🎉

The release is available on:

• npm package (@release-2.x dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jon-esperanza]

This has deprecated Node.js 10 for this node-fetch version due to TextDecoder being used on the global object.

TextDecoder became available on the global object in Node.js 11. Shouldn't this be a breaking change? Is this allowed for 2.x?

[LinusU]

@jon-esperanza the breakage was not intentional, we are reverting this now. Thank you for bringing this to our attention.

revert progress: #1741

[smeet666]

Is there any status on this one, then? Is it abandoned? It's marked as merged, but seems to be reverted.

[jimmywarting]

Yes. it's reverted b/c it broke backward comp.
TextDecoder was not available in those older NodeJS

Must come up with a own solution that strips BOM manually without using it.