Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support reading blob with stream #608

Merged
merged 1 commit into from
Apr 16, 2019
Merged

support reading blob with stream #608

merged 1 commit into from
Apr 16, 2019

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Apr 16, 2019 •
edited

  • added missing ;
  • added missing blob.toString()
  • added missing blob.stream() - this returns a node stream.

closes #604

@bitinn
Copy link
Collaborator

bitinn commented Apr 16, 2019

lgtm, but we should track the issue of separating blob / supporting other blob implementation somewhere.

@jimmywarting
Copy link
Collaborator Author

lgtm, but we should track the issue of separating blob / supporting other blob implementation somewhere.

ok, but we can merge this to the current blob.js implementation anyway and then maybe lift it to some other module

@bitinn bitinn merged commit 432c9b0 into master Apr 16, 2019
@jimmywarting jimmywarting deleted the blob-stream branch April 16, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe add new read methods to blob.js?
2 participants
@jimmywarting @bitinn