Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure search parameters are included in URL path #759

Merged
merged 5 commits into from Apr 13, 2020
Merged

fix: Ensure search parameters are included in URL path #759

merged 5 commits into from Apr 13, 2020

Conversation

terminal69
Copy link
Contributor

#749 can confirm that this is indeed a bug, introduced at commit 0930d6d
path should be pathname + search

xxczaki
xxczaki requested changes Mar 22, 2020
View reviewed changes
Copy link
Member

@xxczaki xxczaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure tests are passed ;)

@terminal69
Copy link
Contributor Author

Please make sure tests are passed ;)

Please see #760

@terminal69 terminal69 requested a review from xxczaki April 7, 2020 06:41
@terminal69
Copy link
Contributor Author

rebased to latest commit on master and tests passed

@jstewmon jstewmon mentioned this pull request Apr 8, 2020
Closed
@Richienb Richienb changed the title fix search params missing from url path fix: Ensure search parameters are included in URL path Apr 12, 2020
@xxczaki xxczaki merged commit 33532c2 into node-fetch:master Apr 13, 2020
This was referenced Apr 13, 2020
Closed
Closed
@LinusU LinusU mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxczaki xxczaki xxczaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terminal69 @xxczaki