Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile CJS modules as a seperate set of files #778

Merged
merged 6 commits into from
Apr 14, 2020
Merged

Compile CJS modules as a seperate set of files #778

merged 6 commits into from
Apr 14, 2020

Conversation

Richienb
Copy link
Member

@Richienb
Switch to seperate babel compilation
578548d 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb changed the title Switch to seperate babel compilation Compile CJS modules as a seperate set of files Apr 14, 2020
@Richienb Richienb mentioned this pull request Apr 14, 2020
Closed
35 tasks
@xxczaki
Copy link
Member

xxczaki commented Apr 14, 2020

We might also want to provide the "module": "src/index.js" and "sideEffects": false fields in our package.json file for bundlers like Webpack.

@xxczaki xxczaki merged commit d15476b into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the babel-time branch April 14, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxczaki xxczaki xxczaki approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Richienb @xxczaki