Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I'm pretty sure there's a better way to handle this but I figured I'd start the conversation here. Yocto generally defines ia32/x64 as x86/x86_64, which generally wouldn't be a problem (I would just override these values in the recipe itself), however when node-ffi is brought in as a dependency I have less control over the situation since npm is sort of "in charge".
The easiest solution seemed to be to just copy those configurations and that allows the build to proceed, however I could see benefit to adding some logic to the gyp file to eliminate the need for duplicating the files. I'm no gyp expert, so maybe some advice here would be helpful.
Cheers!