Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86_64/x86 support #300

Closed
wants to merge 2 commits into from
Closed

Conversation

mbroadst
Copy link

Hey guys, I'm pretty sure there's a better way to handle this but I figured I'd start the conversation here. Yocto generally defines ia32/x64 as x86/x86_64, which generally wouldn't be a problem (I would just override these values in the recipe itself), however when node-ffi is brought in as a dependency I have less control over the situation since npm is sort of "in charge".

The easiest solution seemed to be to just copy those configurations and that allows the build to proceed, however I could see benefit to adding some logic to the gyp file to eliminate the need for duplicating the files. I'm no gyp expert, so maybe some advice here would be helpful.

Cheers!

@TooTallNate
Copy link
Member

This seems more like a gyp / node-gyp issue. x86 should map to ia32 and x86_64 should map to x64. Could you try making an issue at https://github.com/nodejs/node-gyp/issues ?

@mbroadst
Copy link
Author

@TooTallNate actually this looks to be a problem with the meta-nodejs layer for yocto, we already have a method there for converting the arch strings it just wasn't used for the npm bbclass. Sorry for the noise.

@mbroadst mbroadst closed this Apr 17, 2016
@mbroadst mbroadst deleted the add-x86_64-support branch April 17, 2016 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants