Move fs operations into the destroy method #692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the uncaught exception thrown for
VolatileFiles
(re: file streams) when the connection is aborted.This is the proper location to be doing fs operations, since VolatileFile has no fs presence, while PersistentFile does. I also removed the
setTimeout
call becausefs.unlink
is already an async operation.I am curious though if we should propagate an error from
fs.unlink
or not.Fixes #691