Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PersistentFile.toString() doesn't throw #796

Merged
merged 2 commits into from Dec 6, 2021
Merged

fix: PersistentFile.toString() doesn't throw #796

merged 2 commits into from Dec 6, 2021

Conversation

pedroslopez
Copy link
Contributor

Calling toString() on a PersistentFile was throwing:

Uncaught Rejection stack=TypeError: Cannot read property 'newFilename' of undefined
    at PersistentFile.toString (formidable/src/PersistentFile.js:50:42)

It seems like ._file wasn't set anywhere, and toJSON was using these directly anyway.

GrosSacASac
GrosSacASac approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@GrosSacASac GrosSacASac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

@GrosSacASac GrosSacASac merged commit 8355c64 into node-formidable:master Dec 6, 2021
@GrosSacASac
Copy link
Contributor

Published as 3.1.5

@evantahler evantahler mentioned this pull request Dec 6, 2021
Merged
@pedroslopez
Copy link
Contributor Author

Published as 3.1.5

Thanks! How does the v2 situation work? Should I make another pr against v2-latest?

@GrosSacASac
Copy link
Contributor

I recommend to forget v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrosSacASac GrosSacASac GrosSacASac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedroslopez @GrosSacASac