Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples and tests #523

Merged
merged 6 commits into from Dec 4, 2019
Merged

Conversation

GrosSacASac
Copy link
Contributor

fixes #518

@tunnckoCore tunnckoCore marked this pull request as ready for review November 29, 2019 20:24
@tunnckoCore
Copy link
Member

Here we have ba8c8b4 one more test we probably should add too.

I'm not sure what test/legacy is but.. yea.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2019

This pull request introduces 1 alert when merging 9238091 into ca2c2b1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2019

This pull request introduces 1 alert when merging e4e3485 into ca2c2b1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@GrosSacASac
Copy link
Contributor Author

ok you can merge when you want

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2019

This pull request introduces 1 alert when merging 4568007 into ca2c2b1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@tunnckoCore tunnckoCore self-assigned this Nov 29, 2019
@GrosSacASac
Copy link
Contributor Author

Can we merge this ?

@tunnckoCore
Copy link
Member

Probably.

Here we have ba8c8b4 one more test we probably should add too.

I'm not sure what test/legacy is but.. yea.

@GrosSacASac
Copy link
Contributor Author

Are we still using test/legacy. I don't know how to cherry pick from another that so I created a new commit

@GrosSacASac GrosSacASac merged commit 036a809 into master Dec 4, 2019
@GrosSacASac GrosSacASac deleted the improve-examples-and-tests branch December 4, 2019 20:41
@lgtm-com

This comment has been minimized.

Co-Authored-By: yiminghe <yiminghe@gmail.com>
@tunnckoCore
Copy link
Member

tunnckoCore commented Dec 5, 2019

Are we still using test/legacy.

I don't know. Just for consistency for now :D

Tests are failing https://travis-ci.org/node-formidable/node-formidable/jobs/620813815#L214 ...

For some reason it doesn't make array of fields. The form.multiples should be added before the parseCbOk.

DANG! Tests are awfully awful. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test for array parameters support
2 participants