data-uri break the process with no error

[sarvaje]

When you run this code, the process break without any error.

const datauri = 'data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==';
const Canvas = require('canvas-prebuilt');

const image = new Canvas.Image();

image.onerror = function (e) {
    console.log(e);
}
console.log('before');
image.src = datauri;
console.log('after');

Expected output:

before
Error: error while reading from input stream
after

Current output:

before

If I change to canvas everything works as expected (any 1.6.x version).

It works with version 2.0.0-alpha.13 but I can't use it because it is use in jsdom and they don't support version 2 yet.

Maybe this will be fixed after #51 is done.

[chearon]

If I change to canvas everything works as expected (any 1.6.x version).

Are you sure? I don't think that was implemented until Automattic/node-canvas#1193. canvas@next or canvas-prebuilt@next

[sarvaje]

This is working fine with version 1.6.11.

But just for the record:

Are you sure? I don't think that was implemented until Automattic/node-canvas#1193. canvas@next or canvas-prebuilt@next

Sorry, I though that src was supported in all the versions, but in fact I was using this code:

const dataURL = require("data-urls");
const data = dataURL('data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==');
const Canvas = require('canvas-prebuilt');

const image = new Canvas.Image();

image.onerror = function (e) {
    console.log(e);
}
console.log('before');
image.source = data.body;
console.log('after');

I was expecting an error, but the script finished suddenly in image.source = data.body.

But as I said, this is an issue from the past :)

Thanks!!

[chearon]

Oops, you're right, I was thinking of http-style URLs. Glad that fixed it for you.