fix: check for editor in environment variables

To determine which editor to use for commit messages look if $EDITOR or $VISUAL are set in the environment before checking the git config. If no editor is found throw an error. Fixes #745
node-gh · Nov 25, 2019 · 192e142 · 192e142
1 parent b85f5e8
commit 192e142
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/utils.ts b/src/utils.ts
@@ -77,7 +77,15 @@ export function openFileInEditor(fileName: string, msg: string): string {
 
         writeFileSync(filePath, msg)
 
-        const editor = spawnSync('git', ['config', '--global', 'core.editor']).stdout
+        const editor = process.env.EDITOR
+            ? process.env.EDITOR
+            : process.env.VISUAL
+            ? process.env.VISUAL
+            : spawnSync('git', ['config', '--global', 'core.editor']).stdout
+
+        if (!editor) {
+            throw new Error('Could not determine which editor to use')
+        }
 
         execSyncInteractiveStream(`${editor} "${filePath}"`)