Adding gh version module and improving the performance of the version…

… update notifier. #344

lib/base.js

@@ -32,31 +32,36 @@ exports.github = new github({
     version: baseConfig.api.version
 });
 
-function checkVersionPkgFileHandler(err, data) {
-    var notifier,
-        pkg = JSON.parse(data);
+exports.asyncReadPackages = function(callback) {
+    function async(err, data) {
+        if (err) {
+            throw err;
+        }
 
-    notifier = updateNotifier({
+        callback(JSON.parse(data));
+    }
+
+    fs.readFile(path.join(__dirname, '..', 'package.json'), async);
+
+    configs.getPlugins().forEach(function(plugin) {
+        fs.readFile(path.join(
+            configs.getNodeModulesGlobalPath(), plugin, 'package.json'), async);
+    });
+};
+
+exports.notifyVersion = function(pkg) {
+    var notifier = updateNotifier({
         packageName: pkg.name,
         packageVersion: pkg.version
     });
 
     if (notifier.update) {
         notifier.notify();
     }
-}
-
-exports.checkVersion = function(opt_callback) {
-    opt_callback && opt_callback();
-
-    fs.readFile(path.join(__dirname, '..', 'package.json'),
-        checkVersionPkgFileHandler);
+};
 
-    configs.getPlugins().forEach(function(plugin) {
-        fs.readFile(path.join(
-            configs.getNodeModulesGlobalPath(), plugin, 'package.json'),
-            checkVersionPkgFileHandler);
-    });
+exports.checkVersion = function() {
+    exports.asyncReadPackages(exports.notifyVersion);
 };
 
 exports.expandAliases = function(options) {

lib/cmd.js

@@ -105,8 +105,6 @@ exports.run = function () {
         remain = parsed.argv.remain,
         cooked = parsed.argv.cooked;
 
-    operations.push(base.checkVersion);
-
     operations.push(function(callback) {
         var module = remain[0];
 
@@ -139,6 +137,7 @@ exports.run = function () {
 
             User.login(callback);
         }
+        base.checkVersion();
 
          if (tracker.optOut !== undefined) {
             start();

lib/cmds/help.js

@@ -53,6 +53,7 @@ Help.prototype.run = function() {
 
     // Remove help from command list
     files.splice(files.indexOf('help.js'), 1);
+    files.splice(files.indexOf('version.js'), 1);
 
     // Get external plugins
     plugins = configs.getPlugins();

lib/cmds/version.js

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2013-2015, All Rights Reserved.
+ *
+ * Code licensed under the BSD License:
+ * https://github.com/node-gh/gh/blob/master/LICENSE.md
+ *
+ * @author Author <email@email.com>
+ */
+
+'use strict';
+
+// -- Requires -------------------------------------------------------------------------------------
+
+var base = require('../base'),
+    logger = require('../logger');
+
+// -- Constructor ----------------------------------------------------------------------------------
+
+function Version(options) {
+    this.options = options;
+}
+
+// -- Constants ------------------------------------------------------------------------------------
+
+Version.DETAILS = {
+    alias: '',
+    description: 'Print gh version.',
+};
+
+// -- Commands -------------------------------------------------------------------------------------
+
+Version.prototype.run = function() {
+    base.asyncReadPackages(this.printVersion);
+};
+
+Version.prototype.printVersion = function(pkg) {
+    logger.log(pkg.name + ' ' + pkg.version);
+};
+
+exports.Impl = Version;