Added support for pnpm #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/com/github/gradle/node/NodeExtension.kt # src/main/kotlin/com/github/gradle/node/NodePlugin.kt
Merged
|
They could also genuinely be timing out, the big suite takes a lot of time |
|
I'm going to regret merging this since the pnpm tests are the 3 slowest test classes 🥲 |
|
Please consider updating documentation. It's unclear if a pnpm_install task is now available. |
|
@FortinFred there's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #89 by @langrp
Fixes #67
PnpxTaskas pnpx has been deprecated as of pnpm 6 and does no longer appear in the pnpm 7 docsThe tests for MacOS and Windows are passing, but for some reason the tests on Ubuntu seem to hang without producing any error in the end.
Any idea what could go wrong there?