Fix encoding failues on objects containing a 'length' key #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amended my commit to fix style errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case and fixes encoding failures when trying to write data that contains a "length" key or value. Prior to these fixes the added test case would fail with:
Previously the _.createKey*String was using
_.mapwhich, while it worked over objects, was actually a lodash method to work on collections. Evidently the logic lodash used to decide whether something was a collection or an object was to see if it had alengthkey, so objects that did contain a length key were treated as arrays. This PR replaces it with_.forOwnto explicitly iterate over enumerable properties.