Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/list series #47

Merged
merged 26 commits into from
Sep 9, 2014
Merged

Conversation

nichdiekuh
Copy link
Collaborator

I'm afraid the commit history for this minor change looks a bit messy due to the failed travis builds, but the merge should work fine.

This PR introduces a breaking change in getSeriesNames(), hence I've removed versions prior 0.8. from travis.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8c8255d on nichdiekuh:bugfix/list-series into 8183c23 on bencevans:master.

@bencevans
Copy link
Member

Haha that is a lot of history for the changes. Looks good, we'll need to release a major if it's breaking backwards compatibility and maybe add a deprecated notice to responses from influxdb machines where the version is less than .8? Not sure if they'll send that info in the HTTP headers O.o

@nichdiekuh
Copy link
Collaborator Author

Influx returns a Header Tag called "X-Influxdb-Version" but it's not save to rely on the provided information. My production machine for instance returns "InfluxDB vdev (git: b1e6184) (leveldb: 1.15)". I have a self compiled version running on freeBSD

@bencevans
Copy link
Member

For self compiled versions that's fair enough but maybe do it for the
official releases? Maybe even a warning for self compiled? Can't make my
mind up
On 2 Sep 2014 14:36, "Steffen" notifications@github.com wrote:

Influx returns a Header Tag called "X-Influxdb-Version" but it's not save
to rely on the provided information. My production machine for instance
returns "InfluxDB vdev (git: b1e6184) (leveldb: 1.15)". I have a self
compiled version running on freeBSD


Reply to this email directly or view it on GitHub
#47 (comment).

bencevans added a commit that referenced this pull request Sep 9, 2014
@bencevans bencevans merged commit a2ebc6e into node-influx:master Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants