Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #567 unable to start node-debug if default browser check failed #569

Closed
wants to merge 1 commit into from

Conversation

jakub-g
Copy link
Contributor

@jakub-g jakub-g commented Feb 25, 2015

The code of biased-opener didn't properly check for error of x-default-browser and broke node-debug in case where checking for default browser failed for some reason, as in #567

(the fixing commit is jakub-g/biased-opener@72229d4)

@bajtos
Copy link
Member

bajtos commented Mar 4, 2015

@jakub-g what is the status of this issue? I can see that the linked commit has been already released, can we close this issue as resolved?

@jakub-g
Copy link
Contributor Author

jakub-g commented Mar 4, 2015

I released a new version of biased-opener and this is a PR bumping the version in package.json of node inspector.

In fact this is not needed AFAIU since package.json says "biased-opener": "~0.2.2", so npm should take 0.2.3 when someone does npm install. But I always prefer to be explicit about dependencies hence I opened this PR.

Feel free to merge this PR or close it.

@bajtos
Copy link
Member

bajtos commented Mar 4, 2015

I'd rather close this unmerged to keep the git history shorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants