[WIP] Support Node 10

[tcolgate]

No description provided.

[tcolgate]

This fails horribly at the moment.

[tcolgate]

This actually passes the tests but is horribly unsafe.
it seems that the right thing to do would be to wrap the v8 profiler created from the isolate and then store that on the CpuProfiler nan object. At present this is a little beyond me (at least in the time I can allocate)

[tcolgate]

Closing this PR. I'll leave my repo/branch for reference if people find this and are interested.

[Matt-Esch]

@tcolgate can you elaborate a bit more on what is unsafe about this? I might be able to find some time to pick it up.

[tcolgate]

The profiler is accessed without any locking. I have only slightly more than no idea what I'm doing in C++.

[Matt-Esch]

Are there multiple threads in competition for the profiler?

[tcolgate]

I've no idea, but read and write of that variable /probably/ needs to be more controlled.

…

On Sat, 22 Jun 2019, 08:19 Matt-Esch, ***@***.***> wrote: Are there multiple threads in competition for the profiler? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#124?email_source=notifications&email_token=AAASR42AXB545PCZZ3CL3LDP3XG67A5CNFSM4E4TA5W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKC6JQ#issuecomment-504639270>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAASR434YE5W5JXXYQI2HNDP3XG67ANCNFSM4E4TA5WQ> .

[tcolgate]

There have been no commits on this project for 2.5 years. I'm not holding out any hope.