Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channels: openBlockHeight needs to be populated #285

Open
bmancini55 opened this issue Jan 19, 2023 · 0 comments
Open

channels: openBlockHeight needs to be populated #285

bmancini55 opened this issue Jan 19, 2023 · 0 comments
Labels
refactor Refactor existing code

Comments

@bmancini55
Copy link
Member

  • For funder this should be in the attachFundingTx method - which is arguably a confusing method name if it's funder specific.
  • For fundee this should be in the attachChannelOpen method and should capture the current block height
  • Appropriate documentation adjustments should be made as well to each of these methods and the state transitions
@bmancini55 bmancini55 added the refactor Refactor existing code label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmancini55