fix: using Buffer.alloc(size) instead of new Buffer(size) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
May 15, 2018
lib/byte.js
Outdated
| @@ -21,7 +21,7 @@ function ByteBuffer(options) { | |||
| if (array) { | |||
| this._bytes = array; | |||
| } else { | |||
| this._bytes = new Buffer(this._size); | |||
| this._bytes = Buffer.alloc(this._size); | |||
There was a problem hiding this comment.
我还专门查了的，把 10.0.0 看成 0.10.0 了，但是 ci 里 4 是过了的
There was a problem hiding this comment.
node 4 有，0.10.0 和 0.12.0 没有，还要支持吗？
There was a problem hiding this comment.
|
1.4.1 |
ChALkeR
added a commit
to ChALkeR/security-wg
that referenced
this pull request
May 15, 2018
vdeturckheim
pushed a commit
to nodejs/security-wg
that referenced
this pull request
May 15, 2018
patrickm68
added a commit
to patrickm68/security-wg-process
that referenced
this pull request
Sep 14, 2023
mattstern31
added a commit
to mattstern31/security-wg-process
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Buffer(size)没有 fill 0，可能会导致信息泄露。并且 node 10 里已经 deprecated，用 Buffer.alloc / Buffer.from / Buffer.allocUnsafe 代替https://snyk.io/vuln/npm:byte:20180512