feat: throw error when create server port is missing (#62)

node-modules · Jan 11, 2023 · eb890c3 · eb890c3
1 parent 2f5e91a
commit eb890c3
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -2,20 +2,15 @@
 Sharing Connection among Multi-Process Nodejs
 
 [![NPM version][npm-image]][npm-url]
-[![build status][travis-image]][travis-url]
+[![CI](https://github.com/node-modules/cluster-client/actions/workflows/nodejs.yml/badge.svg)](https://github.com/node-modules/cluster-client/actions/workflows/nodejs.yml)
 [![Test coverage][codecov-image]][codecov-url]
-[![David deps][david-image]][david-url]
 [![Known Vulnerabilities][snyk-image]][snyk-url]
 [![npm download][download-image]][download-url]
 
 [npm-image]: https://img.shields.io/npm/v/cluster-client.svg?style=flat-square
 [npm-url]: https://npmjs.org/package/cluster-client
-[travis-image]: https://img.shields.io/travis/node-modules/cluster-client.svg?style=flat-square
-[travis-url]: https://travis-ci.org/node-modules/cluster-client
 [codecov-image]: https://codecov.io/gh/node-modules/cluster-client/branch/master/graph/badge.svg
 [codecov-url]: https://codecov.io/gh/node-modules/cluster-client
-[david-image]: https://img.shields.io/david/node-modules/cluster-client.svg?style=flat-square
-[david-url]: https://david-dm.org/node-modules/cluster-client
 [snyk-image]: https://snyk.io/test/npm/cluster-client/badge.svg?style=flat-square
 [snyk-url]: https://snyk.io/test/npm/cluster-client
 [download-image]: https://img.shields.io/npm/dm/cluster-client.svg?style=flat-square
@@ -299,4 +294,4 @@ class APIClient extends APIClientBase {
 
 For more information, you can refer to the [discussion](https://github.com/eggjs/egg/issues/322)
 
-[MIT](LICENSE)
+[MIT](LICENSE)
diff --git a/lib/server.js b/lib/server.js
@@ -1,5 +1,3 @@
-'use strict';
-
 const debug = require('debug')('cluster-client:lib:server');
 const net = require('net');
 const Base = require('sdk-base');
@@ -170,6 +168,9 @@ class ClusterServer extends Base {
    */
   static async create(name, port) {
     const key = `${name}@${port}`;
+    if (typeof port !== 'number') {
+      throw new Error(`[ClusterClient.server.create:${name}] port should be a number, but got ${JSON.stringify(port)}`);
+    }
     let instance = serverMap.get(port);
     if (instance && !instance.isClosed) {
       debug('create %j instance exists', key);

diff --git a/lib/wrapper/base.js b/lib/wrapper/base.js
@@ -36,7 +36,6 @@ class WrapperBase extends Base {
    * @class
    */
   constructor(options) {
-    options = options || {};
     super(options);
     debug('new WrapperBase({ port: %j, isLeader: %j })', options.port, options.isLeader);
     this[subInfo] = new Map();

diff --git a/test/server.test.js b/test/server.test.js
@@ -1,5 +1,3 @@
-'use strict';
-
 const mm = require('mm');
 const path = require('path');
 const coffee = require('coffee');
@@ -31,4 +29,22 @@ describe('test/server.test.js', () => {
     assert(server2);
     await ClusterServer.close('previous-closed', server1);
   });
+
+  it('should throw error when port is not a number', async function() {
+    await assert.rejects(async () => {
+      await ClusterServer.create('same-name', undefined);
+    }, /port should be a number, but got undefined/);
+    await assert.rejects(async () => {
+      await ClusterServer.create('same-name', null);
+    }, /port should be a number, but got null/);
+    await assert.rejects(async () => {
+      await ClusterServer.create('same-name');
+    }, /port should be a number, but got undefined/);
+    await assert.rejects(async () => {
+      await ClusterServer.create('same-name', 'foo');
+    }, /port should be a number, but got "foo"/);
+    await assert.rejects(async () => {
+      await ClusterServer.create('same-name', '0');
+    }, /port should be a number, but got "0"/);
+  });
 });