Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error when create server port is missing #62

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 11, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2
Copy link
Member Author

fengmk2 commented Jan 11, 2023

需要更好的提示

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #62 (953d2d5) into master (698105f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          19       19           
  Lines        2285     2285           
  Branches      417      418    +1     
=======================================
  Hits         2249     2249           
  Misses         36       36           
Impacted Files Coverage Δ
lib/wrapper/base.js 99.04% <ø> (-0.01%) ⬇️
lib/server.js 98.80% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit eb890c3 into master Jan 11, 2023
@fengmk2 fengmk2 deleted the valid-port branch January 11, 2023 01:17
fengmk2 pushed a commit that referenced this pull request Jan 11, 2023
[skip ci]

## [3.4.0](v3.3.3...v3.4.0) (2023-01-11)

### Features

* throw error when create server port is missing ([#62](#62)) ([eb890c3](eb890c3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant